Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe use of eval #1

Open
cristianstaicu opened this issue Apr 8, 2016 · 0 comments
Open

Unsafe use of eval #1

cristianstaicu opened this issue Apr 8, 2016 · 0 comments

Comments

@cristianstaicu
Copy link

In file index.js, the following uses of eval may have unexpected consequences:

function setItemPath(dup, obj, objectPath, path) {
    var value = findValue(objectPath, obj);
    path += '=value;';
    eval(path);
}
function deleteItemValue(dup, duplicatePath) {
    var path = buildDuplicatePath(dup, duplicatePath);
    path = 'delete ' + path;
    eval(path);
}

I know it is not very likely, but if an attacker can control one of the parameters to your module, it may do something like this:

mask.mask(model, ['id"]; console["log"]("my evil code was run");//'])

My suggestions: get rid of eval by using the bracket notation, validate the input to eval by using some regex or use a more heavyweight sanitization package like:
https://www.npmjs.com/package/eval-sanitizer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant