Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install issue with grpc #12

Closed
tLupus1978 opened this issue Jan 2, 2021 · 1 comment
Closed

npm install issue with grpc #12

tLupus1978 opened this issue Jan 2, 2021 · 1 comment

Comments

@tLupus1978
Copy link

when executing in current branch, grpc build fails (in magicMirror docker)
../deps/grpc/src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.cc: In function ‘grpc_grpclb_request* grpc_grpclb_request_create(const char*)’: ../deps/grpc/src/core/ext/filters/client_channel/lb_policy/grpclb/load_balancer_api.cc:70:10: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 128 equals destination size [-Wstringop-truncation] strncpy(req->initial_request.name, lb_service_name,

after searching grpc/grpc-node#922 i figured out, that you must execute first
npm install request
and then
npm install
this does the trick

If you see a better approach, tell me. Nevertheless, streams are still not playing :-(

@mcintyrehh
Copy link
Owner

Sorry this is absurdly late but I've added the request package to package.json, and added an HLS proxy to the module to get around CORS/Permission errors! I'll be cleaning this repo up some more over the next week or so.

Thanks so much for the issue submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants