You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
RedisPersistence.prototype.streamOfflinePackets = function(client, cb) {
var that = this;
if (this._cleanClient(client)) {
return;
}
that._client.lrange("packets:" + client.id, -1, 10000, function(err, results) {
}
It looks the usage of LRANGE is not correct.
According to http://redis.io/commands/lrange , the command "LRANGE packets:client_id -1 1000" would only get last element in "packets:client_id". As a result, streamOfflinePackets only send out one offline packet. I suppose this is not correct.
Please correct me if I'm wrong.
The text was updated successfully, but these errors were encountered:
In https://github.com/mcollina/mosca/blob/master/lib/persistence/redis.js line 319, it is
It looks the usage of LRANGE is not correct.
According to http://redis.io/commands/lrange , the command "LRANGE packets:client_id -1 1000" would only get last element in "packets:client_id". As a result, streamOfflinePackets only send out one offline packet. I suppose this is not correct.
Please correct me if I'm wrong.
The text was updated successfully, but these errors were encountered: