-
-
Notifications
You must be signed in to change notification settings - Fork 506
publish subscribes and connected-client #182
Conversation
@@ -241,10 +242,44 @@ function Server(opts, callback) { | |||
} | |||
]); | |||
|
|||
var SysNewTopic = "$SYS/broker-id/new/clients"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broker-id should be built on the broker's id :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right.
Do you prefer to having the published message only client id in string, or having it a JSON {clientId: xxxxx}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the client id in the string. However you may leave that in the JSON too, it does not harm.
Good one! Do you think it's ready for merging and releasing? |
We've deployed this change in our test environment today. There is no issue yet. It should work well. Just not sure whether new published message would burden backend ascoltatori. In our env, about 10 connect/subscribe per second works well. |
I think you intended 'new subscribe' message. What do you think about changing the default of |
That should be good. |
Turn |
publish subscribes and connected-client
Released as 0.24.0. |
Fix #92
Publish new client by default would break a lot of unit test cases. So, I add one
server.options
namedpublishNewClient
to switch the feature, which is off by default.