Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

Fix closing issues and clientID specification #57

Merged
merged 5 commits into from
Sep 18, 2013

Conversation

chriswiggins
Copy link
Contributor

As per issues #55 and #56.

I have not been able to create test cases yet but I can confirm this works with the client code we have developed internally

@mcollina
Copy link
Collaborator

Thanks! :).

Could you add one test for the "old client" thing, just connecting two clients and see the first one disconnected?

@mcollina
Copy link
Collaborator

May I ask who do you work for? :). I'll just add a link in the wiki or the README!

@chriswiggins
Copy link
Contributor Author

Have now added the uni test for the old client and confirmed it works :-)

Rather you just put my name in the README as this was done in personal time anyway

Remove console log output from testing the tester :-)
@chriswiggins
Copy link
Contributor Author

So it didn't work for a secure server. Will just have to wait and see if the changes I've made fix that (I have confirmed on my side though)

@chriswiggins
Copy link
Contributor Author

OK so works on v0.10 but not v0.8. @mcollina, can you take a peek at what I'm checking and suggest changes I can make to ensure it works on v0.8?

@mcollina
Copy link
Collaborator

I'll merge and fix it. The main issue is the different implementation of TLS between 0.8 and 0.10, in particular it seems that 'destroyed' do not exist in 0.8.

mcollina added a commit that referenced this pull request Sep 18, 2013
Fix closing issues and clientID specification
@mcollina mcollina merged commit a0a9c3d into moscajs:master Sep 18, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants