Adding support for encoding Uint8Arrays using bin format family #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moozzyk
commented
Oct 19, 2017
| }) | ||
| }) | ||
|
|
||
| t.end() |
There was a problem hiding this comment.
No decoding tests since bin family is decoded to Buffers. This code has not changed and already has test coverage.
|
@mcollina - friendly ping... |
mcollina
reviewed
Oct 26, 2017
lib/encoder.js
Outdated
| } else if (obj && obj.readUInt32LE) { | ||
| } else if (obj && (obj.readUInt32LE || obj instanceof Uint8Array)) { | ||
| if (obj instanceof Uint8Array) { | ||
| obj = new Buffer(obj) |
There was a problem hiding this comment.
the new Buffer() constructor is depracted. Can you use Buffeer.from?
|
🆙📅 |
|
Thanks! |
This was referenced Mar 12, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #58