[Feature] Hide private spaces to guest

[hipoloco]

In addition to this feature, I think the guests should not see private spaces. Although guests can not see information from private spaces, they neither should know that exist them.

[hipoloco]

Some days ago I implemented a workaround for this feature (on v2.3.0 code). I don't know if this is the best solution. but it works. I edited _list_view.html.haml and _thumbnail_view.html.haml files as shown below:

_list_view.html.haml

-# locals:
-#   spaces (array of Space)
-#   user_spaces (array of Space): the spaces to which the user belongs
-#   extended (boolean): show extended information
-#   show_join_request (boolean): show link to a join request (if it exists)

- show_join_request ||= false
- extended ||= false

#spaces
  .content-block-middle.clearfix
    %ul.list-texts
      - if !user_signed_in?
        - filtered_spaces = spaces.select { |space| space.public == true }
      - else
        - filtered_spaces = spaces
      - if filtered_spaces.count > 0
        - filtered_spaces.each do |space|
          - is_member = user_spaces && user_spaces.include?(space)
          %li.list-text{:name => space.permalink}
            = render "spaces/unified_space", :space => space, :is_member => is_member, :extended => extended, :show_join_request => show_join_request
      - else
        - if !user_signed_in?
          = t(".no_public_spaces")
        - else
          = t(".no_spaces")

_thumbnail_view.html.haml

-# locals:
-#  spaces (array of Space)
-#  show_join_request (boolean): show link to a join request (if it exists)

- show_join_request ||= false

%ul.list-thumbnails
  - if !user_signed_in?
    - filtered_spaces = spaces.select { |space| space.public == true }
  - else
    - filtered_spaces = spaces
  - if filtered_spaces.count > 0
    - filtered_spaces.each do |space|
      %li.list-thumbnail-wrapper{ :name => space.permalink }
        = render "spaces/space_thumbnail", :space => space, :show_join_request => show_join_request
  - else
    - if !user_signed_in?
      = t(".no_public_spaces")
    - else
      = t(".no_spaces")

Also I created "no_public_spaces" string on each mconf.yml language file.