From 968ae6fb6ea3006476d0444d918d78dcc67beefa Mon Sep 17 00:00:00 2001
From: Claas Augner <495429+caugner@users.noreply.github.com>
Date: Thu, 21 Dec 2023 19:13:59 +0100
Subject: [PATCH] fix(deps): pin Node.js to v18.17 + use .nvmrc from
 interactive-examples (#1625)

* chore(workflows): use node-version-file

* fix(deps): pin Node.js to v18.17

Our tests fail with later minor versions.

* fix(workflows): use .nvmrc from interactive-examples
---
 .github/workflows/npm-published-simulation.yml | 18 +++++++++---------
 .github/workflows/test.yml                     |  2 +-
 .nvmrc                                         |  2 +-
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/npm-published-simulation.yml b/.github/workflows/npm-published-simulation.yml
index 88336d5eb..a6a96d0bb 100644
--- a/.github/workflows/npm-published-simulation.yml
+++ b/.github/workflows/npm-published-simulation.yml
@@ -14,26 +14,26 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - name: Setup Node.js environment (interactive-examples)
-        uses: actions/setup-node@v4
-        with:
-          node-version: 18
-
       - name: Checkout mdn/interactive-examples
         uses: actions/checkout@v4
         with:
           repository: mdn/interactive-examples
           path: interactive-examples
 
-      - name: Install all packages (interactive-examples)
-        working-directory: interactive-examples
-        run: npm ci
-
       - name: Checkout this repository
         uses: actions/checkout@v4
         with:
           path: bob
 
+      - name: Setup Node.js environment (interactive-examples)
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: "interactive-examples/.nvmrc"
+
+      - name: Install all packages (interactive-examples)
+        working-directory: interactive-examples
+        run: npm ci
+
       - name: Install all packages (bob)
         working-directory: bob
         run: npm ci
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 8487de603..02d51c760 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -9,7 +9,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version-file: ".nvmrc"
       - name: Install dependencies
         run: npm ci
       - name: Prepack
diff --git a/.nvmrc b/.nvmrc
index 3f430af82..edf176c67 100644
--- a/.nvmrc
+++ b/.nvmrc
@@ -1 +1 @@
-v18
+v18.17