From cd51f9e3c42d2bdf05cd86058c5db3287d09027e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= <philip@foolip.org>
Date: Thu, 28 Jan 2021 13:42:26 +0100
Subject: [PATCH] Update data for when href (not xlink:href) can be used in SVG
 (#6603)

Test case used for <image href>:

```svg
<svg width="400" height="200"
     xmlns="http://www.w3.org/2000/svg"
     xmlns:xlink="http://www.w3.org/1999/xlink">
  <image xlink:href="https://mdn.mozillademos.org/files/6457/mdn_logo_only_color.png" x="0" height="200" width="200"/>
  <image href="https://mdn.mozillademos.org/files/6457/mdn_logo_only_color.png" x="200" height="200" width="200"/>
</svg>
```

Test case used for <use href>:

```svg
<svg viewBox="0 0 30 10"
     xmlns="http://www.w3.org/2000/svg"
     xmlns:xlink="http://www.w3.org/1999/xlink">
  <circle id="myCircle" cx="5" cy="5" r="4" stroke="black"/>
  <use xlink:href="#myCircle" x="10" fill="green"/>
  <use href="#myCircle" x="20" fill="green"/>
</svg>
```

Based on these tests, the change was narrowed down to Chrome 50, and
this commit pinpointed:
https://chromium.googlesource.com/chromium/src/+/2f0b655515af2df03d41d4f894e0dd59d5cb6411

At the time, SVGURIReference was used in these C++ classes:

https://chromium.googlesource.com/chromium/src/+/2f0b655515af2df03d41d4f894e0dd59d5cb6411/third_party/WebKit/Source/core/svg/SVGAElement.h#32
https://chromium.googlesource.com/chromium/src/+/2f0b655515af2df03d41d4f894e0dd59d5cb6411/third_party/WebKit/Source/core/svg/SVGCursorElement.h#35
https://chromium.googlesource.com/chromium/src/+/2f0b655515af2df03d41d4f894e0dd59d5cb6411/third_party/WebKit/Source/core/svg/SVGFEImageElement.h#35
https://chromium.googlesource.com/chromium/src/+/2f0b655515af2df03d41d4f894e0dd59d5cb6411/third_party/WebKit/Source/core/svg/SVGPatternElement.h#40
https://chromium.googlesource.com/chromium/src/+/2f0b655515af2df03d41d4f894e0dd59d5cb6411/third_party/WebKit/Source/core/svg/SVGTextPathElement.h#46
https://chromium.googlesource.com/chromium/src/+/2f0b655515af2df03d41d4f894e0dd59d5cb6411/third_party/WebKit/Source/core/svg/SVGUseElement.h#37

The following classes are the same, but for these there's no BCD entry
for the namespaceless href attribute, so they're not updated:
https://chromium.googlesource.com/chromium/src/+/2f0b655515af2df03d41d4f894e0dd59d5cb6411/third_party/WebKit/Source/core/svg/SVGFilterElement.h#42
https://chromium.googlesource.com/chromium/src/+/2f0b655515af2df03d41d4f894e0dd59d5cb6411/third_party/WebKit/Source/core/svg/SVGGradientElement.h#44
https://chromium.googlesource.com/chromium/src/+/2f0b655515af2df03d41d4f894e0dd59d5cb6411/third_party/WebKit/Source/core/svg/SVGImageElement.h#36
https://chromium.googlesource.com/chromium/src/+/2f0b655515af2df03d41d4f894e0dd59d5cb6411/third_party/WebKit/Source/core/svg/SVGMPathElement.h#34
https://chromium.googlesource.com/chromium/src/+/2f0b655515af2df03d41d4f894e0dd59d5cb6411/third_party/WebKit/Source/core/svg/SVGScriptElement.h#38

Data is mirror for Chromium browsers expect Edge, which is mostly set to
"12" already and where it's null would require additional testing.
---
 svg/attributes/href.json   | 12 ++++++------
 svg/elements/a.json        | 12 ++++++------
 svg/elements/cursor.json   | 16 ++++++++--------
 svg/elements/feImage.json  | 10 +++++-----
 svg/elements/pattern.json  | 12 ++++++------
 svg/elements/textPath.json | 14 ++++++++------
 svg/elements/use.json      | 12 ++++++------
 7 files changed, 45 insertions(+), 43 deletions(-)

diff --git a/svg/attributes/href.json b/svg/attributes/href.json
index a059a6a249c330..8399f50d1c9b10 100644
--- a/svg/attributes/href.json
+++ b/svg/attributes/href.json
@@ -6,10 +6,10 @@
           "mdn_url": "https://developer.mozilla.org/docs/Web/SVG/Attribute/href",
           "support": {
             "chrome": {
-              "version_added": true
+              "version_added": "50"
             },
             "chrome_android": {
-              "version_added": true
+              "version_added": "50"
             },
             "edge": {
               "version_added": "12"
@@ -24,10 +24,10 @@
               "version_added": true
             },
             "opera": {
-              "version_added": true
+              "version_added": "37"
             },
             "opera_android": {
-              "version_added": true
+              "version_added": "37"
             },
             "safari": {
               "version_added": "12.1"
@@ -36,10 +36,10 @@
               "version_added": "12.2"
             },
             "samsunginternet_android": {
-              "version_added": true
+              "version_added": "5.0"
             },
             "webview_android": {
-              "version_added": true
+              "version_added": "50"
             }
           },
           "status": {
diff --git a/svg/elements/a.json b/svg/elements/a.json
index 2deaf5dbfcb5ad..d7d65eacf4a211 100644
--- a/svg/elements/a.json
+++ b/svg/elements/a.json
@@ -99,10 +99,10 @@
           "__compat": {
             "support": {
               "chrome": {
-                "version_added": true
+                "version_added": "50"
               },
               "chrome_android": {
-                "version_added": true
+                "version_added": "50"
               },
               "edge": {
                 "version_added": "12"
@@ -117,10 +117,10 @@
                 "version_added": true
               },
               "opera": {
-                "version_added": true
+                "version_added": "37"
               },
               "opera_android": {
-                "version_added": null
+                "version_added": "37"
               },
               "safari": {
                 "version_added": "12.1"
@@ -129,10 +129,10 @@
                 "version_added": "12.2"
               },
               "samsunginternet_android": {
-                "version_added": true
+                "version_added": "5.0"
               },
               "webview_android": {
-                "version_added": true
+                "version_added": "50"
               }
             },
             "status": {
diff --git a/svg/elements/cursor.json b/svg/elements/cursor.json
index 954a9be185fe82..5ac2688abaf0ee 100644
--- a/svg/elements/cursor.json
+++ b/svg/elements/cursor.json
@@ -24,10 +24,10 @@
               "version_added": null
             },
             "opera": {
-              "version_added": false
+              "version_added": "15"
             },
             "opera_android": {
-              "version_added": false
+              "version_added": "14"
             },
             "safari": {
               "version_added": "3"
@@ -52,10 +52,10 @@
           "__compat": {
             "support": {
               "chrome": {
-                "version_added": null
+                "version_added": "50"
               },
               "chrome_android": {
-                "version_added": null
+                "version_added": "50"
               },
               "edge": {
                 "version_added": null
@@ -70,10 +70,10 @@
                 "version_added": null
               },
               "opera": {
-                "version_added": false
+                "version_added": "37"
               },
               "opera_android": {
-                "version_added": false
+                "version_added": "37"
               },
               "safari": {
                 "version_added": "12.1"
@@ -82,10 +82,10 @@
                 "version_added": "12.2"
               },
               "samsunginternet_android": {
-                "version_added": null
+                "version_added": "5.0"
               },
               "webview_android": {
-                "version_added": null
+                "version_added": "50"
               }
             },
             "status": {
diff --git a/svg/elements/feImage.json b/svg/elements/feImage.json
index 73a4f121cf91fc..05f1379fe508f6 100644
--- a/svg/elements/feImage.json
+++ b/svg/elements/feImage.json
@@ -52,10 +52,10 @@
           "__compat": {
             "support": {
               "chrome": {
-                "version_added": true
+                "version_added": "50"
               },
               "chrome_android": {
-                "version_added": true
+                "version_added": "50"
               },
               "edge": {
                 "version_added": "12"
@@ -70,7 +70,7 @@
                 "version_added": true
               },
               "opera": {
-                "version_added": true
+                "version_added": "37"
               },
               "opera_android": {
                 "version_added": null
@@ -82,10 +82,10 @@
                 "version_added": "12.2"
               },
               "samsunginternet_android": {
-                "version_added": true
+                "version_added": "5.0"
               },
               "webview_android": {
-                "version_added": true
+                "version_added": "50"
               }
             },
             "status": {
diff --git a/svg/elements/pattern.json b/svg/elements/pattern.json
index e8e71fcc382611..03fa1e1040c216 100644
--- a/svg/elements/pattern.json
+++ b/svg/elements/pattern.json
@@ -99,10 +99,10 @@
           "__compat": {
             "support": {
               "chrome": {
-                "version_added": null
+                "version_added": "50"
               },
               "chrome_android": {
-                "version_added": null
+                "version_added": "50"
               },
               "edge": {
                 "version_added": null
@@ -117,10 +117,10 @@
                 "version_added": null
               },
               "opera": {
-                "version_added": null
+                "version_added": "37"
               },
               "opera_android": {
-                "version_added": null
+                "version_added": "37"
               },
               "safari": {
                 "version_added": "12.1"
@@ -129,10 +129,10 @@
                 "version_added": "12.2"
               },
               "samsunginternet_android": {
-                "version_added": null
+                "version_added": "5.0"
               },
               "webview_android": {
-                "version_added": null
+                "version_added": "50"
               }
             },
             "status": {
diff --git a/svg/elements/textPath.json b/svg/elements/textPath.json
index f749124b818d59..6f82c7adbe3ffa 100644
--- a/svg/elements/textPath.json
+++ b/svg/elements/textPath.json
@@ -54,11 +54,11 @@
           "__compat": {
             "support": {
               "chrome": {
-                "version_added": true,
+                "version_added": "50",
                 "notes": "Only accepts references to path elements. Basic shapes (rect, circle, ellipse, line, polygon, polyline) won't work."
               },
               "chrome_android": {
-                "version_added": true,
+                "version_added": "50",
                 "notes": "Only accepts references to path elements. Basic shapes (rect, circle, ellipse, line, polygon, polyline) won't work."
               },
               "edge": {
@@ -74,10 +74,12 @@
                 "version_added": true
               },
               "opera": {
-                "version_added": true
+                "version_added": "37",
+                "notes": "Only accepts references to path elements. Basic shapes (rect, circle, ellipse, line, polygon, polyline) won't work."
               },
               "opera_android": {
-                "version_added": true
+                "version_added": "37",
+                "notes": "Only accepts references to path elements. Basic shapes (rect, circle, ellipse, line, polygon, polyline) won't work."
               },
               "safari": {
                 "version_added": "12.1",
@@ -88,11 +90,11 @@
                 "notes": "Only accepts references to path elements. Basic shapes (rect, circle, ellipse, line, polygon, polyline) won't work."
               },
               "samsunginternet_android": {
-                "version_added": true,
+                "version_added": "5.0",
                 "notes": "Only accepts references to path elements. Basic shapes (rect, circle, ellipse, line, polygon, polyline) won't work."
               },
               "webview_android": {
-                "version_added": true,
+                "version_added": "50",
                 "notes": "Only accepts references to path elements. Basic shapes (rect, circle, ellipse, line, polygon, polyline) won't work."
               }
             },
diff --git a/svg/elements/use.json b/svg/elements/use.json
index 9a2ea048884e5b..530910ed18320f 100644
--- a/svg/elements/use.json
+++ b/svg/elements/use.json
@@ -197,10 +197,10 @@
           "__compat": {
             "support": {
               "chrome": {
-                "version_added": true
+                "version_added": "50"
               },
               "chrome_android": {
-                "version_added": true
+                "version_added": "50"
               },
               "edge": {
                 "version_added": "12"
@@ -215,10 +215,10 @@
                 "version_added": true
               },
               "opera": {
-                "version_added": true
+                "version_added": "37"
               },
               "opera_android": {
-                "version_added": true
+                "version_added": "37"
               },
               "safari": {
                 "version_added": "12.1"
@@ -227,10 +227,10 @@
                 "version_added": "12.2"
               },
               "samsunginternet_android": {
-                "version_added": true
+                "version_added": "5.0"
               },
               "webview_android": {
-                "version_added": true
+                "version_added": "50"
               }
             },
             "status": {