Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onsecuritypolicyviolation to Window and Document? #12334

Closed
hamishwillee opened this issue Sep 10, 2021 · 3 comments
Closed

Add onsecuritypolicyviolation to Window and Document? #12334

hamishwillee opened this issue Sep 10, 2021 · 3 comments
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Comments

@hamishwillee
Copy link
Contributor

I added onsecuritypolicyviolation to the global handlers in #12289.

However I "think" that onsecuritypolicyviolation is also needed in BCD on Window and Document too. Can you please confirm? Reasoning below.

The Window and Document handlers were in the spec before being added to the global handlers.

  • Testing shows that onsecuritypolicyviolation is present on Chrome in Window and Document (but not in elements). i.e. it implements these
  • Notes indicate it is present Document in Safari but not Window
  • For completeness, FF92 did not implement these.

If these do need a BCD entry, what versions could be used? Just set to true, false appropriately? We can kind of guess at these from SecurityPolicyViolationEvent but it would be a guess - because we know this guess does not work for Firefox.

@queengooborg queengooborg added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 10, 2021
@Elchi3
Copy link
Member

Elchi3 commented Sep 10, 2021

This issue seems to be an instance of #12290. I don't have an answer yet, linking this for inspiration/context.

@hamishwillee
Copy link
Contributor Author

@Elchi3 Well, there is no way I can reflect the right versions that onsecuritypolicyviolation are available on Window and Document using GlobalEventHandlers. So from correctness of the data it certainly makes sense to split them out.

However I will leave this alone until a decision is made.

@Elchi3
Copy link
Member

Elchi3 commented Oct 10, 2022

The data structures here were updated in #16728 to add the event on Window and Document.

It seems that more research on the data is needed and that was filed as #16992. Closing here. Continue in #16992.

@Elchi3 Elchi3 closed this as completed Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

No branches or pull requests

3 participants