Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove needs-release-note label? #14228

Closed
queengooborg opened this issue Dec 28, 2021 · 1 comment
Closed

Remove needs-release-note label? #14228

queengooborg opened this issue Dec 28, 2021 · 1 comment
Labels
infra Infrastructure issues (npm, GitHub Actions, releases) of this project

Comments

@queengooborg
Copy link
Contributor

With our new release note system, I believe that we can simply remove this label. What do you think @ddbeck?
@queengooborg queengooborg added the infra Infrastructure issues (npm, GitHub Actions, releases) of this project label Dec 28, 2021
@ddbeck ddbeck mentioned this issue Dec 29, 2021
Merged
@ddbeck
Copy link
Collaborator

ddbeck commented Dec 29, 2021

No, we should continue to set the label for PRs with noteworthy changes that won't be generated automatically. For example, in v4.1.2 the note for #14003 would never have been generated automatically.

There are now fewer circumstances where the label is required, however. I've opened #14285 to revise the docs.

@ddbeck ddbeck closed this as completed Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra Infrastructure issues (npm, GitHub Actions, releases) of this project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddbeck @queengooborg