-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unittest to validate TypeScript types #16590
Comments
https://github.com/mdn/browser-compat-data/releases/tag/v5.0.2
That sounds like a breaking change 🤔, there should be some deprecated typedefs until 6.x. |
TypeScript definitions were not covered by semantic versioning during this release. However, going forward, they will be (especially since they're auto-generated). I've just opened up a fix for the typo, and all of those linter typedef imports will be fixed in #16333. |
That's not all. Please reopen and add tests before closing this.
|
I closed this issue because any remaining TypeScript definition issues will be resolved in #16333, when BCD's internals are migrated to TypeScript and depend on these types. I plan to release an update to BCD later this week to deploy TypeScript fixes. |
Ah, wait: I now see this is talking about writing a unittest. Apologies, I thought this was just about the invalid TypeScript definition. For the unittest, if you're down to write a PR to add one (and fix up any issues in separate PRs), I'd be happy to review and merge it. |
For example,
BrowserNames
is now gone but the schema still refers to it, causing build failure:browser-compat-data/schemas/compat-data.schema.json
Line 184 in 2888cf5
There are also several occurrences of
import('../../types').Identifier
in linters which are now all broken:browser-compat-data/test/linter/test-status.js
Line 7 in 420c23b
The text was updated successfully, but these errors were encountered: