-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a script to generate GitHub release notes #3199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool little automation here :) Thanks, Daniel! 👍
I have two things I wondered about while running the for the latest release just now. See comments inline.
And then I wonder where this should live. tests/ is probably okay? (render.js is in there as well). Or should we start an infamous utils folder? 😄
Will have a closer look at the code and the newly added devDependency once I have more time available.
Just ran through the release process myself for the first time and fixed up a few small issues I ran into (typos and setting the prerelease checkbox—that last one we'll have to change when we hit 1.0, I guess). |
This will conflict with #2338, which I’d like to merge first for reasons outlined in #2338 (comment). |
@ExE-Boss the conflict being the |
OK, I'm going to:
I'll do this by the end of the day Wednesday, so it can be ready for @Elchi3 to try it again on the next release. |
@Elchi3 I've undone adding a dependency (the resulting code isn't too gnarly, I hope) and updated the docs. Please give this a try on the next release. Thank you! |
Oh yeah to address the earlier question: yes, I kinda think we should have a |
Or maybe a |
I've tried this yesterday and it worked flawlessly. I'm glancing over it again now, but I think it is all good :) I like the idea of a scripts/ directory. render.js should live there as well. Maybe more in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving and merging this. 🎉
Prompted by comments on mdn#3199.
Prompted by comments on #3199.
Based on our discussion on documenting release notes #3158 (comment) I wrote a script to generate (some but not all) release notes and pre-populate the GitHub release page.
I wasn't able to automate all of it, so I prompt for some information instead. Let me know what you think!