Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter: Enforce more property sorting #3505

Closed
Elchi3 opened this issue Feb 22, 2019 · 0 comments · Fixed by #16052
Closed

Linter: Enforce more property sorting #3505

Elchi3 opened this issue Feb 22, 2019 · 0 comments · Fixed by #16052
Labels
idle Issues and pull requests with no recent activity linter Issues or pull requests regarding the tests / linter of the JSON files.

Comments

@Elchi3
Copy link
Member

Elchi3 commented Feb 22, 2019

In #3469 (comment) @chrisdavidmills mentions that the properties in support objects should rather be sorted. Currently this can occur:

{
  "version_removed": "7.0",
  "prefix": "webkit",
  "version_added": true
}

Desired would be:

{
  "prefix": "webkit",
  "version_added": true,
  "version_removed": "7.0"
}

Instead of asking people to do that in reviews, the linter should enforce this style.

@Elchi3 Elchi3 added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Feb 22, 2019
@github-actions github-actions bot added the idle Issues and pull requests with no recent activity label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no recent activity linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant