Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split comparison operators #6276

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Split comparison operators #6276

merged 1 commit into from
Jun 10, 2020

Conversation

wbamberg
Copy link
Contributor

@wbamberg wbamberg commented Jun 9, 2020

This PR is part of mdn/stumptown-content#411, in which we want to have separate pages for the comparison operators.

It:

  • splits the compat data for comparison operators into 8 separate JSON files, one for each operator
  • updates the mdn_url to point to the new pages
  • adds spec_url
  • renames "identity" and "non-identity" to "strict equality" and "string inequality" to match the titles of and terminology used in the new pages.

@ghost ghost added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Jun 9, 2020
Elchi3
Elchi3 approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thank you so much, Will! 👍

@Elchi3 Elchi3 merged commit a9e2b27 into mdn:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @Elchi3