Drop now-nonexistent Streams API constructors #6314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructors below are not in the current Streams spec. * ReadableByteStreamController() * ReadableStreamBYOBRequest() * ReadableStreamDefaultController() * WritableStreamDefaultController() See whatwg/streams#1043 for confirmation from one of the spec editors that the constructors should be de-documented.
sideshowbarker
force-pushed
the
sideshowbarker/streams-api-constructors-remove
branch
from
ef7c2f8 to
c760196
Compare
queengooborg
added
the
data:api
|
I noticed this needed to be labeled for release notes, but then realized that it landed in v1.0.27, so I updated the release notes for that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructors below are not in the current Streams spec.
ReadableByteStreamController()ReadableStreamBYOBRequest()ReadableStreamDefaultController()WritableStreamDefaultController()See whatwg/streams#1043 for confirmation from one of the spec editors that the constructors should be de-documented.
All of the corresponding MDN articles have been deleted.
The BCD data showed that none of them had ever been implemented in any browser engines — with the exception of
ReadableStreamDefaultController(), which the data indicated as being implemented in Firefox. But I think that may have been incorrect — because I can’t find any evidence that constructor was in fact ever actually implemented in Firefox.