Remove the api.Element.accessKey entry #6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already an entry on HTMLElement with better data: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/accessKey There is no indication that accessKey has been on Element in any browser. This can be confirmed by these tests in old browsers: http://mdn-bcd-collector.appspot.com/tests/api/Element/accessKey http://mdn-bcd-collector.appspot.com/tests/api/HTMLElement/accessKey Tested in IE11 to complement the findings from Confluence for browsers released ~5 years ago: https://web-confluence.appspot.com/#!/catalog?releases=%5B%22Edge_13.10586_Windows_10.0%22,%22Chrome_47.0.2526.73_Windows_10.0%22,%22Firefox_45.0_Windows_10.0%22,%22Safari_9.1.3_OSX_10.11.6%22%5D&q=%22accessKey%22 Fixes mdn#6697.
github-actions
bot
added
the
data:api
sideshowbarker
approved these changes
Sep 23, 2020
|
I merged this and #6751 on the assumption that we can update the release notes later, without needing to block merging of these first |
|
@sideshowbarker Yes, that's correct—I write the release notes when I do the merge. Though I had been thinking that we should get the notes into Git as well—then we could have contributors directly add release notes too. |
|
Opened #6759 for tracking release notes in Git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already an entry on HTMLElement with better data:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/accessKey
There is no indication that accessKey has been on Element in any
browser. This can be confirmed by these tests in old browsers:
http://mdn-bcd-collector.appspot.com/tests/api/Element/accessKey
http://mdn-bcd-collector.appspot.com/tests/api/HTMLElement/accessKey
Tested in IE11 to complement the findings from Confluence for browsers
released ~5 years ago:
https://web-confluence.appspot.com/#!/catalog?releases=%5B%22Edge_13.10586_Windows_10.0%22,%22Chrome_47.0.2526.73_Windows_10.0%22,%22Firefox_45.0_Windows_10.0%22,%22Safari_9.1.3_OSX_10.11.6%22%5D&q=%22accessKey%22
Fixes #6697.