Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the “MediaQueryListListener” feature #7210

Merged

Conversation

sideshowbarker
Copy link
Member

This change drops the “MediaQueryListListener” feature. It’s not the name of an actual API but instead apparently was just a kind of shorthand for something that’s no longer part of any spec anyway. See https://wiki.developer.mozilla.org/docs/Web/API/MediaQueryListListener

This change drops the “MediaQueryListListener” feature. It’s not the
name of an actual API but instead apparently was just a kind of
shorthand for something that’s no longer part of any spec anyway. See
https://wiki.developer.mozilla.org/docs/Web/API/MediaQueryListListener
@sideshowbarker sideshowbarker added the KR: Real BCD Key Result: Eliminate true/null values and replace them with "real" values. label Oct 31, 2020
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 31, 2020
@foolip
Copy link
Contributor

foolip commented Nov 4, 2020

@ddbeck can you redirect https://wiki.developer.mozilla.org/en-US/docs/Web/API/MediaQueryListListener before we merge this?

@sideshowbarker
Copy link
Member Author

@ddbeck can you redirect https://wiki.developer.mozilla.org/en-US/docs/Web/API/MediaQueryListListener before we merge this?

I can redirect it — so can you actually, I think: In the top editing bar of the MDN editing UI, you should see that the furthest-right button is a curved-arrow icon with Create a Redirect tooltip text. When you push push that it pops up a dialog that lets you choose the article name to redirect to.

@foolip
Copy link
Contributor

foolip commented Nov 5, 2020

Aha, I thought special powers were needed. I've redirected it now, but https://developer.mozilla.org/docs/Web/API/MediaQueryListListener hasn't updated yet.

@foolip
Copy link
Contributor

foolip commented Nov 5, 2020

Going through some of the docs for this, I think the interesting thing to communicate to web developers is whether MediaQueryList supports addListener, addEventListener, or both. How the callback function for addListener was specified is not in itself observable to web developers.

What gives me doubt is what to do with these notes still left in MDN:
https://wiki.developer.mozilla.org/en-US/docs/Web/API/MediaQueryList/addListener#Syntax
https://wiki.developer.mozilla.org/en-US/docs/Web/API/MediaQueryList/removeListener#Syntax

Is there anything about those that should be preserved?

@sideshowbarker
Copy link
Member Author

Going through some of the docs for this, I think the interesting thing to communicate to web developers is whether MediaQueryList supports addListener, addEventListener, or both.

Yeah, agreed

How the callback function for addListener was specified is not in itself observable to web developers.

What gives me doubt is what to do with these notes still left in MDN:
https://wiki.developer.mozilla.org/en-US/docs/Web/API/MediaQueryList/addListener#Syntax
https://wiki.developer.mozilla.org/en-US/docs/Web/API/MediaQueryList/removeListener#Syntax

Is there anything about those that should be preserved?

No, I think — nothing there that needs to be preserved (given as you noted that how the callback function is specified isn’t observable).

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 12, 2020

So what needs to happen here? Remove the mentions of MediaQueryListListener on MDN and merge this?

@sideshowbarker
Copy link
Member Author

So what needs to happen here? Remove the mentions of MediaQueryListListener on MDN and merge this?

I think so — but I guess we need confirmation from @foolip

@queengooborg
Copy link
Contributor

Foolip's been away from BCD for a while -- reading through this thread, I'd say that this is ready to go. If those notes don't need to be preserved, then we can push go and remove this!

@sideshowbarker
Copy link
Member Author

I'd say that this is ready to go. If those notes don't need to be preserved, then we can push go and remove this!

OK, thanks — then I’m happy if you (or anybody other than me, since I’m the author for the patch) can go ahead and push the button to merge this

@queengooborg queengooborg merged commit 41bfaef into mdn:master Nov 18, 2020
@sideshowbarker sideshowbarker deleted the sideshowbarker/MediaQueryListListener-remove branch November 18, 2020 23:52
@sideshowbarker
Copy link
Member Author

Thanks for the merge!

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 19, 2020

So it's not exactly explicit from the process we discussed previously, but I'd like to make sure that we clean up any content messes that follow from our feature removals before merging. By redirecting the MediaQueryListListener page back to MediaQueryList, we created oddities on the pages for MediaQueryList.addListener() and .removeListener(). I'll fix those pages now, but, in the future, I'd like open questions about content problems to be answered (with content changes or issues against mdn/sprints) before merging.

@queengooborg queengooborg removed the KR: Real BCD Key Result: Eliminate true/null values and replace them with "real" values. label Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants