Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a linter to make sure deprecated flag is also applied to children #7348

Closed
saschanaz opened this issue Nov 12, 2020 · 5 comments · Fixed by #24810
Closed

Add a linter to make sure deprecated flag is also applied to children #7348

saschanaz opened this issue Nov 12, 2020 · 5 comments · Fixed by #24810
Labels
idle Issues and pull requests with no recent activity linter Issues or pull requests regarding the tests / linter of the JSON files.

Comments

@saschanaz
Copy link
Contributor

See https://github.com/mdn/browser-compat-data/pull/7311/files#r522266719

@queengooborg queengooborg added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Nov 12, 2020
@queengooborg
Copy link
Contributor

+1 for this. Should we also extend this to experimental?

@saschanaz
Copy link
Contributor Author

Good idea! I'll do that as a followup, as the current PR already modifies multiple files and I see some issues there.

@queengooborg
Copy link
Contributor

queengooborg commented Nov 13, 2020

I was going through the list of PRs, and I noticed that you have a linter written for preventing both experimental and deprecated together (#6813). I'm thinking that it would make sense to combine all three linter functions (deprecated consistency, experimental consistency, and no deprecated and experimental together) into a single test-status.js file? (Future plan still, but it'll certainly help reduce the amount of repeated code we have.)

@saschanaz
Copy link
Contributor Author

Yay good idea, just renamed both to test-status.js. I can rebase them once either one is merged.

@github-actions github-actions bot added the idle Issues and pull requests with no recent activity label May 25, 2022
@caugner
Copy link
Contributor

caugner commented Jan 7, 2025

Fixed via #24810.

@caugner caugner closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no recent activity linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
4 participants
@caugner @saschanaz @queengooborg and others