Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid deprecation flags #7709

Closed
saschanaz opened this issue Dec 14, 2020 · 3 comments
Closed

Remove invalid deprecation flags #7709

saschanaz opened this issue Dec 14, 2020 · 3 comments
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Comments

@saschanaz
Copy link
Contributor

saschanaz commented Dec 14, 2020 •
edited
Loading

While I was working on saschanaz/types-web@7c382a0 I found some invalid flags:

  • DOMPointReadOnly#matrixTransform: I see no reason to mark this as deprecated. This is a valid API.
  • HTMLImageElement#useMap: Same.
  • HTMLMapElement#areas: While a selector call can easily replace this, this is still a useful shortcut and the spec does not mark it as deprecated.
  • HTMLMapElement#name: This is actually "required" by the spec.

    The attribute must be present and must have a non-empty value with no ASCII whitespace

  • HTMLScriptElement#type: You know, type=module.
  • SVGPathElement#getPointAtLength and SVGPathElement#getTotalLength: Both are moved to the superclass SVGGeometryElement. Those should be just removed.
sideshowbarker added a commit to w3c/browser-compat-data that referenced this issue Dec 14, 2020
@sideshowbarker
Undeprecate the usemap attribute
b0908c1 
This change marks the usemap content/markup attribute of the img element
and the usemap IDL/DOM attribute of the HTMLImageElement interface
deprecated:false. They were mistakenly marked deprecated:false in
mdn@b3ea219

Relates to mdn#7709
@sideshowbarker sideshowbarker mentioned this issue Dec 14, 2020
Merged
sideshowbarker added a commit to w3c/browser-compat-data that referenced this issue Dec 14, 2020
@sideshowbarker
Undeprecate "type" attribute of script element
c819087 
This change marks the "type" content/markup attribute of the script
element and the "type" IDL/DOM attribute of the HTMLScriptElement
interface deprecated:false. They were mistakenly marked deprecated:true
in mdn@a6f6d39

Relates to mdn#7709
@sideshowbarker sideshowbarker mentioned this issue Dec 14, 2020
Merged
sideshowbarker added a commit to w3c/browser-compat-data that referenced this issue Dec 14, 2020
@sideshowbarker
Undeprecate img/HTMLImageElement usemap attribute
051e65c 
This change marks the usemap content/markup attribute of the img element
and the useMap IDL/DOM attribute of the HTMLImageElement interface
deprecated:false. They were mistakenly marked deprecated:true in
mdn@b3ea219

Relates to mdn#7709
@sideshowbarker
Copy link
Member

I found some invalid flags:
…
HTMLImageElement#useMap: Same.
…
HTMLScriptElement#type: You know, type=module.

oops, those two are my fault — thanks for catching those. I’ve raised #7711 and #7712 with fixes

sideshowbarker added a commit to w3c/browser-compat-data that referenced this issue Dec 14, 2020
@sideshowbarker
Undeprecate DOMPointReadOnly.p.matrixTransform
c68a0c8 
This change marks DOMPointReadOnly.p.matrixTransform deprecated:false.
Per https://drafts.fxtf.org/geometry/#dom-dompointreadonly-matrixtransform
it’s not currently deprecated (and it’s not clear it should ever have
been marked deprecated:true to begin with).

Related: mdn#7709
@sideshowbarker sideshowbarker mentioned this issue Dec 14, 2020
Merged
sideshowbarker added a commit to w3c/browser-compat-data that referenced this issue Dec 14, 2020
@sideshowbarker
Undeprecate HTMLMapElement "areas" & "name" attrs
6a0079a 
This change marks the "areas" & "name" attributes of the HTMLMapElement
interface deprecated:false, because the spec does not deprecate them.

Related: mdn#7709
@sideshowbarker sideshowbarker mentioned this issue Dec 14, 2020
Merged
@sideshowbarker
Copy link
Member

DOMPointReadOnly#matrixTransform: I see no reason to mark this as deprecated. This is a valid API.

➡ #7713

HTMLMapElement#areas: While a selector call can easily replace this, this is still a useful shortcut and the spec does not mark it as deprecated.

HTMLMapElement#name: This is actually "required" by the spec.
> The attribute must be present and must have a non-empty value with no ASCII whitespace

➡️ #7719

queengooborg pushed a commit that referenced this issue Dec 14, 2020
@sideshowbarker
Undeprecate HTMLMapElement "areas" & "name" attrs (#7719)
250088d 
This change marks the "areas" & "name" attributes of the HTMLMapElement
interface deprecated:false, because the spec does not deprecate them.

Related: #7709
queengooborg pushed a commit that referenced this issue Dec 14, 2020
@sideshowbarker
Undeprecate DOMPointReadOnly.p.matrixTransform (#7713)
fe41fc6 
This change marks DOMPointReadOnly.p.matrixTransform deprecated:false.
Per https://drafts.fxtf.org/geometry/#dom-dompointreadonly-matrixtransform
it’s not currently deprecated (and it’s not clear it should ever have
been marked deprecated:true to begin with).

Related: #7709
queengooborg pushed a commit that referenced this issue Dec 14, 2020
@sideshowbarker
Undeprecate "type" attribute of script element (#7712)
fe2c2d2 
This change marks the "type" content/markup attribute of the script
element and the "type" IDL/DOM attribute of the HTMLScriptElement
interface deprecated:false. They were mistakenly marked deprecated:true
in a6f6d39

Relates to #7709
queengooborg pushed a commit that referenced this issue Dec 14, 2020
@sideshowbarker
Undeprecate img/HTMLImageElement usemap attribute (#7711)
afd6a5a 
This change marks the usemap content/markup attribute of the img element
and the useMap IDL/DOM attribute of the HTMLImageElement interface
deprecated:false. They were mistakenly marked deprecated:true in
b3ea219

Relates to #7709
@queengooborg queengooborg added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 14, 2020
@ddbeck ddbeck mentioned this issue May 4, 2021
Closed
@saschanaz
Copy link
Contributor Author

Fixed by #7711, #7712, #7713, #7719, #9479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sideshowbarker @saschanaz @queengooborg