Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript.builtins.Array.isArray - isArray present since Node 6 #8890

Closed
paceaux opened this issue Jan 28, 2021 · 1 comment
Closed

javascript.builtins.Array.isArray - isArray present since Node 6 #8890

paceaux opened this issue Jan 28, 2021 · 1 comment
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript

Comments

@paceaux
Copy link

paceaux commented Jan 28, 2021

What information was incorrect, unhelpful, or incomplete?

Node.js Version is incorrect for Array.isArray

What did you expect to see?

Expected to see version 6.4, not Node v 10.

Did you test this? If so, how?

  1. Used iNVM to install node 6.4
  2. Ran the below in the node terminal:
var arr = [];
Array.isArray(arr); 

It returned true;

This compatibility chart shows support in 6.4 https://node.green/#ES2015-built-ins-Proxy

MDN page report details
@ddbeck ddbeck added data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript wontfix 👎 labels Jan 29, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented Jan 29, 2021

Thanks for reporting this, @paceaux. I did some checking and I'm satisfied by the data for Array.isArray. A few points:

  • I didn't see v10.0.0 mentioned in the MDN page included in this report. I'm guessing this is an (understandable) misreading of v0.10.0 (note the leading zero). But if I'm mistaken and you saw an issue with a different page, then feel free to post a follow-up comment linking the problem page.
  • I double-checked that Array.isArray([]) in Node.js v0.10.0 and it works as expected. This is the first version of Node.js that BCD records. See the schema documentation on initial versions and What should be the minimum listed version of nodejs? #6861, if you'd like to know why we don't record versions before Node.js v0.10.0.
  • The node.green table entry you linked to is about the behavior of Proxy with Array.isArray. As far as I can tell, we do not record data for that specific interaction, but we do correctly report Proxy as introduced in Node.js v6.0.0 (see Proxy.json for detail). Conversely, node.green doesn't appear to track the availability of the Array.isArray static method, so I can't directly compare our results to theirs for the method itself.

All that said, if I've missed anything, please let us know. In the mean time, I'm going to close this issue. Thanks again!

@ddbeck ddbeck closed this as completed Jan 29, 2021
@queengooborg queengooborg closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

No branches or pull requests

4 participants
@ddbeck @paceaux @queengooborg and others