Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove StaticRange.p.toRange #10288

Merged
merged 1 commit into from
May 6, 2021
Merged

Remove StaticRange.p.toRange #10288

merged 1 commit into from
May 6, 2021

Conversation

sideshowbarker
Copy link
Member

@sideshowbarker sideshowbarker commented May 5, 2021 •
edited
Loading

StaticRange.p.toRange isn’t part of any spec, was only ever implemented in Chrome — but way back at Chrome 60. So this change removes it, per #10288 (comment)

Related MDN change: mdn/content#4723

@sideshowbarker sideshowbarker requested a review from foolip May 5, 2021 11:15
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 5, 2021
sideshowbarker added a commit to mdn/content that referenced this pull request May 5, 2021
@sideshowbarker
Mark StaticRange.p.toRange non-standard
2dd035b 
StaticRange.p.toRange isn’t part of any spec, so this change marks it
non-standard.

Related BCD change: mdn/browser-compat-data#10288
@foolip
Copy link
Contributor

foolip commented May 5, 2021

Per https://mdn-bcd-collector.appspot.com/tests/api/StaticRange/toRange this isn't actually in Chrome. Looks like it was removed in https://chromium.googlesource.com/chromium/src/+/e2b8278dd5aaf5a6ec415aa5e7dd828f17b644f6 and this entry should actually be removed entirely.

@sideshowbarker
Remove StaticRange.p.toRange
9469034 
StaticRange.p.toRange isn’t part of any spec, was only ever implemented
in Chrome — but way back at Chrome 60. So this change removes it, per
mdn#10288 (comment)

Related MDN change: mdn/content#4723
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/StaticRange.p.toRange-nonstandard branch from 2006f87 to 9469034 Compare May 5, 2021 11:31
@sideshowbarker sideshowbarker changed the title Mark StaticRange.p.toRange non-standard Remove StaticRange.p.toRange May 5, 2021
@sideshowbarker
Copy link
Member Author

Per mdn-bcd-collector.appspot.com/tests/api/StaticRange/toRange this isn't actually in Chrome. Looks like it was removed in chromium.googlesource.com/chromium/src/+/e2b8278dd5aaf5a6ec415aa5e7dd828f17b644f6 and this entry should actually be removed entirely.

OK, I’ve amended the commit to remove it — as well as updating the PR description accordingly.

foolip
foolip approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.mozilla.org/en-US/docs/Web/API/StaticRange/toRange also needs to be removed, so approving but not merging, so this could go together with a MDN PR.

sideshowbarker added a commit to mdn/content that referenced this pull request May 5, 2021
@sideshowbarker
Remove StaticRange.p.toRange
e6183b5 
StaticRange.p.toRange isn’t part of any spec, and was only ever implemented
in Chrome — but way back at Chrome 60. So this change removes it, per
mdn/browser-compat-data#10288 (comment)

Related BCD change: mdn/browser-compat-data#10288
@sideshowbarker sideshowbarker mentioned this pull request May 5, 2021
Merged
@sideshowbarker
Copy link
Member Author

developer.mozilla.org/en-US/docs/Web/API/StaticRange/toRange also needs to be removed, so approving but not merging, so this could go together with a MDN PR.

OK, I’ve amended the mdn/content#4723 change to remove it completely from MDN.

wbamberg pushed a commit to mdn/content that referenced this pull request May 5, 2021
@sideshowbarker
Remove StaticRange.p.toRange (#4723)
9516999 
StaticRange.p.toRange isn’t part of any spec, and was only ever implemented
in Chrome — but way back at Chrome 60. So this change removes it, per
mdn/browser-compat-data#10288 (comment)

Related BCD change: mdn/browser-compat-data#10288
@ddbeck ddbeck merged commit 4dd7e02 into mdn:main May 6, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request May 6, 2021
@ddbeck
Add release note for mdn#10288
a2b274d
ddbeck added a commit that referenced this pull request May 6, 2021
@ddbeck
Prepare release v3.3.3 (#10338)
0ea392d 
* Start v3.3.3 release

* Add release note for #9975

* Add release note for #10175

* Add release note for #10225

* Add release note for #10261

* Add release note for #10288

* Add stats
@sideshowbarker sideshowbarker deleted the sideshowbarker/StaticRange.p.toRange-nonstandard branch May 6, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sideshowbarker @foolip @ddbeck @queengooborg