Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Android WebView 4.1 #10577

Merged
merged 3 commits into from
May 24, 2021
Merged

Remove Android WebView 4.1 #10577

merged 3 commits into from
May 24, 2021

Conversation

queengooborg
Copy link
Contributor

This PR removes Android WebView 4.1 from our data (as a part of #10524). Since the WebKit versions match for both WebView 4.1 and 4, it's highly doubtful that there would be anything added in 4.1 that isn't present in 4. Additionally, this PR changes everywhere where WebView is set to 4.1 and replaces the value with 4 in its place.

@github-actions github-actions bot added data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS labels May 22, 2021
foolip
foolip approved these changes May 22, 2021
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea, but would like @ddbeck or @Elchi3 to also review.

jonjarry
jonjarry reviewed May 23, 2021
View reviewed changes
Copy link

@jonjarry jonjarry left a comment •
edited by queengooborg
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Spam]

Elchi3
Elchi3 approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Same here, none of these features look like they would typically require a higher Android version. Engine support seems the important factor here.

@Elchi3 Elchi3 merged commit e7e4008 into mdn:main May 24, 2021
@queengooborg queengooborg deleted the browsers/remove-webview-4.1 branch May 24, 2021 10:41
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request May 27, 2021
@ddbeck
Add release notes for mdn#10568, mdn#10576, and mdn#10577
bb4665a
ddbeck added a commit that referenced this pull request May 27, 2021
@ddbeck
Prepare release v3.3.5 (#10656)
27be85b 
* Bump to v3.3.5

* Add release note for #10571

* Add release note for #10548

* Add release note for #10550

* Add release note for #10551

* Add release note for #10128

* Add release notes for #10568, #10576, and #10577

* Add stats

* Update stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjarry jonjarry jonjarry left review comments

@Elchi3 Elchi3 Elchi3 approved these changes

@foolip foolip foolip approved these changes

@lucalves lucalves lucalves approved these changes

Assignees
No one assigned
Labels
data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@queengooborg @Elchi3 @foolip @lucalves @jonjarry