Change Safari 6.1 to 7 where the iOS version is already 7 #11184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
foolip
force-pushed
the
simple-safari-6.1
branch
from
99b91e9 to
73cbb82
Compare
foolip
commented
Jun 21, 2021
api/Window.json
Outdated
| }, | ||
| { | ||
| "version_added": "6", | ||
| "version_removed": "6.1", | ||
| "version_removed": "7", |
There was a problem hiding this comment.
This case is a little bit irregular since there's no corresponding prefixed entry for safari_ios. There probably should be.
There was a problem hiding this comment.
http://mdn-bcd-collector.appspot.com/tests/api/Window/webkitCancelAnimationFrame reveals there's more wrong here, the API is still supported!
I'll back out the change from this PR.
foolip
commented
Jun 21, 2021
foolip
force-pushed
the
simple-safari-6.1
branch
from
73cbb82 to
3518851
Compare
foolip
force-pushed
the
simple-safari-6.1
branch
from
3518851 to
e9bedae
Compare
queengooborg
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This subset of #11156
does not need much scrutiny, as this results in the expected matching
of Safari and iOS versions. There may still be errors in this data, but
then it's wrong for both Safaris.
Part of #9423.