Remove obsolete worker.close() and related entries #11557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
foolip
added
the
needs content update
|
Hmm, more can be removed here in BCD. There's an |
foolip
changed the title
foolip
force-pushed
the
rm-WorkerGlobalScope-close
branch
from
6e663cf to
28e097e
Compare
|
LGTM but conflict needs to be solved. Content work: mdn/content#7033 |
There are close() methods on both DedicatedWorkerGlobalScope and SharedWorkerGlobalScope in BCD and MDN already: https://developer.mozilla.org/en-US/docs/Web/API/DedicatedWorkerGlobalScope/close https://developer.mozilla.org/en-US/docs/Web/API/SharedWorkerGlobalScope/close There's a note here that explains how this came about: https://developer.mozilla.org/en-US/docs/Web/API/SharedWorkerGlobalScope/close#browser_compatibility However, we need not keep this data or even have notes about it: https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#apis-moved-on-the-prototype-chain Furthermore, there is no close event or onclose property. It's not clear when this was removed from browsers, but the onclose property is at least not supported anywhere today. This also updates some existing data: Verified supported in Opera 10.6: http://mdn-bcd-collector.appspot.com/tests/api/DedicatedWorkerGlobalScope/close http://mdn-bcd-collector.appspot.com/tests/api/SharedWorkerGlobalScope/close Firefox for Android data was also bumped to 29, it's implausible that it was supported much earlier on Android. It's probably the result of copying data from DedicatedWorkerGlobalScope, which is marked as supported since firefox for Android 4.
foolip
force-pushed
the
rm-WorkerGlobalScope-close
branch
from
28e097e to
236c5c0
Compare
|
@Elchi3 rebased to resolve conflicts. |
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jul 22, 2021
ddbeck
removed
needs-release-note 📰
needs content update
ddbeck
added a commit
that referenced
this pull request
Jul 22, 2021
* Bump version to v3.3.12 * Add release note for #11661 * Add release notes for #11173 and #11175 * Add release note for #11534 * Add release note for #11544 * Add release note for #11551 * Add release note for #11555 * Add release note for #11556 * Add release note for #11557 * Add release note for #11633 * Add release note for #11636 * Add release note for #11637 * Add release note for #11530 * Add release stats and date * Consolidate Safari for iOS version consolidation notes * Format PR URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are close() methods on both
DedicatedWorkerGlobalScope and SharedWorkerGlobalScope in BCD and MDN
already:
https://developer.mozilla.org/en-US/docs/Web/API/DedicatedWorkerGlobalScope/close
https://developer.mozilla.org/en-US/docs/Web/API/SharedWorkerGlobalScope/close
There's a note here that explains how this came about:
https://developer.mozilla.org/en-US/docs/Web/API/SharedWorkerGlobalScope/close#browser_compatibility
However, we need not keep this data or even have notes about it:
https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#apis-moved-on-the-prototype-chain
Furthermore, there is no close event or onclose property. It's not clear
when this was removed from browsers, but the onclose property is at
least not supported anywhere today.
This also updates some existing data:
Verified supported in Opera 10.6:
http://mdn-bcd-collector.appspot.com/tests/api/DedicatedWorkerGlobalScope/close
http://mdn-bcd-collector.appspot.com/tests/api/SharedWorkerGlobalScope/close
Firefox for Android data was also bumped to 29, it's implausible that it
was supported much earlier on Android. It's probably the result of
copying data from DedicatedWorkerGlobalScope, which is marked as
supported since firefox for Android 4.