Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v4.0.2 #12238

Merged
merged 8 commits into from
Sep 2, 2021
Merged

Prepare release v4.0.2 #12238

merged 8 commits into from
Sep 2, 2021

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Sep 1, 2021

Notes for Florian:

  • Publishing docs

  • Useful npm scripts:

    • npm run release-pulls
    • npm run release-stats
  • If you've got the GitHub CLI (gh) and jq, you can diff features added/removed by a given (merged) PR:

    $ node scripts/diff-features.js $(gh pr view --json mergeCommit --jq '.mergeCommit.oid' PULL_REQUEST_URL)

    Example (which still needs a release note):

    $ node scripts/diff-features.js $(gh pr view --json mergeCommit --jq '.mergeCommit.oid' https://github.com/mdn/browser-compat-data/pull/11518)
  • Find placeholders by searching the release notes file for TK.

@github-actions github-actions bot added dependencies Pull requests that update a dependency package or file. docs Issues or pull requests regarding the documentation of this project. infra Infrastructure issues (npm, GitHub Actions, releases) of this project labels Sep 1, 2021
@Elchi3 Elchi3 marked this pull request as ready for review September 2, 2021 12:23
Copy link
Collaborator Author

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions

RELEASE_NOTES.md Outdated

### WindowOrWorkerGlobalScope removal

To no longer expose mixins, the following features have been moved from `api.WindowOrWorkerGlobalScope` (or `api.Window` for two cases) to the global `api.*` namespace. The features' worker support is now indicated using `worker_support` sub-features.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually link to the PR, for details, background, etc. Something like this?

Suggested change
To no longer expose mixins, the following features have been moved from `api.WindowOrWorkerGlobalScope` (or `api.Window` for two cases) to the global `api.*` namespace. The features' worker support is now indicated using `worker_support` sub-features.
To no longer expose mixins, the following features have been moved from `api.WindowOrWorkerGlobalScope` (or `api.Window` for two cases) to the global `api.*` namespace. The features' worker support is now indicated using `worker_support` sub-features. ([#XYZ](https://github.com/…))

@Elchi3 Elchi3 merged commit 9a4b198 into mdn:main Sep 2, 2021
@ddbeck ddbeck deleted the prepare-release-2021-09-02 branch April 1, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency package or file. docs Issues or pull requests regarding the documentation of this project. infra Infrastructure issues (npm, GitHub Actions, releases) of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants