Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant api.HTMLSourceElement.keySystem feature #12383

Merged

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Sep 13, 2021

This PR removes the irrelevant keySystem member of the HTMLSourceElement API as per the corresponding data guidelines. The lack of current support has been confirmed by the mdn-bcd-collector project (v3.3.0), even if the current BCD suggests support.

This PR removes the irrelevant `keySystem` member of the `HTMLSourceElement` API as per the corresponding [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features). The lack of current support has been confirmed by the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.2.12), even if the current BCD suggests support.
@queengooborg queengooborg added needs-release-note 📰 needs content update This PR needs a corresponding update to mdn/content to update the documentation and removed needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Sep 13, 2021
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 13, 2021
@queengooborg
Copy link
Contributor Author

Additional comments: it seems that the media.eme.enabled flag has been enabled by default, but this feature is not around in modern Firefox versions. None of the other browsers support the feature. I don't see anything in the spec about this feature, and the MDN page is already deleted.

@foolip
Copy link
Contributor

foolip commented Sep 14, 2021

This was probably a precursor to https://developer.mozilla.org/docs/Web/API/MediaKeySystemAccess/keySystem

"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLSourceElement/keySystem",
"support": {
"chrome": {
"version_added": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that Chromium doesn't has keySystem on HTMLSourceElement.

"version_added": true
},
"edge": {
"version_added": "≤18"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to also have been wrong, https://developer.mozilla.org/docs/Web/API/MediaKeySystemAccess/keySystem return false in Edge 18.

@foolip foolip merged commit c101ed1 into mdn:main Sep 14, 2021
@queengooborg queengooborg deleted the api/HTMLSourceElement/keySystem/removal branch September 14, 2021 06:58
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Sep 16, 2021
ddbeck added a commit that referenced this pull request Sep 16, 2021
* Bump version to v4.0.4

* Add release note for #12335

* Add release note for #12366

* Add release note for #12376

* Add release note for #12383

* Add release note for #12403

* Simplify list of removals

* Set release date

* Add stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants