-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP WWW-Authenticate - add scheme and algorithm info #12446
Conversation
@ddbeck If you could push this to someone for review that would be great. |
Yeah, this makes sense. A couple things to keep in mind: One additional question at the end here, however.
The immediate cause of the failures is that URLs are missing fragments, for deep linking to the relevant portion of the spec. That said, we typically use the https://datatrack.ietf.org/ URLs. And I didn't check whether the linked specs would validate. Also, the URL will need to be in w3c/browser-specs (there's a separate test for that at the end, after you've cleared the schema validation).
I'm not decided on this yet, but why both? On initial reading, I was thinking, should this be on |
Just making a note here that in a recent call, Hamish and I decided to include both WWW-Auth and Auth data, then deduplicate later if needed. |
Thanks! Yes, you also said I could use |
d3cff14
to
713ad02
Compare
@ddbeck Before I mirror the results I wanted to make sure that the WWW-Authenticate information will get accepted. There are two parts to that - data and specs. Re the data, this is pretty "loose" because it is hard for me to verify. We kind of agreed this was OK.
Is the above good enough submission of the data? Re the specs, I'm getting errors. |
Yes, but in the case of Chrome, please link to any other docs materials you're relying on here in the PR. For the IETF specs, use the rfc-editor URLs, for consistency with what's in the browser-specs repo already. |
Thanks. I'll update the specs on Friday. W.r.t. chrome supporting data,
I know they support MD5 because if you support digest at all before now that is what you supported. I believe they don't support SHA512 because they'd not implement 256 if they already had 512. |
@ddbeck OK, Status updated 9 Nov.
If that goes through I'll duplicate for the other header. |
9e466f0
to
b987176
Compare
f94424d
to
2455981
Compare
@ddbeck Happy days. NTLM spec removed and I have mirrored the WWW-authenticate to the Authorization header (changing the main spec url only). Should be good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
WWW-Authenticate and Authorization together are the HTTP headers used in the general HTTP authentication framework. Note, compatibility for these should mirror each other.
Thing is, this is a framework, not a specific implementation. So saying that Firefox or whatever supports this in version X tells you very little. The useful compatibility information is
What I have done here is a draft that attempts to start adding that information. I really don't want to go all the way with this, but I'd like to at least cover the methods supported by Firefox and Chrome, down to algorithm level. Right now this just starts the job for Firefox, since there is not much point me chasing this too far if BCD team disagree with this approach.
What I know.
Questions
Fixes #12370. Actually, it's a draft to help test whether the approach is reasonable.