Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api.CanvasRenderingContext2D.drawImage.smoothing_downscaling #12796

Conversation

queengooborg
Copy link
Contributor

This PR removes the smoothing_downscaling subfeature of the drawImage method of CanvasRenderingContext2D. This feature was a remnant from the old wiki migration. There is nothing in the docs explaining what exactly this means, so it's unclear how to test support for this. With that, plus the fact that this isn't a spec-defined behavior, I think it makes sense to simply remove this subfeature from BCD.

@queengooborg queengooborg added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API needs-release-note 📰 labels Oct 11, 2021
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this isn't valuable enough to preserve, and pinning down a version for Safari would be hard. I tried to make a test case in another PR that I can't find now, but it's hard to say what exactly counts as enough smoothing.

I don't think this is an entirely clear cut case, however, so I'll defer to @ddbeck or @Elchi3 to approve and merge.

@ddbeck
Copy link
Collaborator

ddbeck commented Oct 12, 2021

I'd be willing to go along with removing this as matter of practicality alone. It's a silly web koan: if a feature can't be observed, is it a feature at all?

Plus the spec backs us up here. It looks like this feature came about because of this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1360415 and this change to the spec whatwg/html@5854cb0. At present, the spec says:

This specification does not define the precise algorithm to use when scaling an image down, or when scaling an image up when the imageSmoothingEnabled attribute is set to true.

Seems like UAs are supposed to be free to do as they wish here and I'm not sure it helps web developers to imply that this behavior is supposed to have any consistency (even if it does).

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit 4d5ae47 into mdn:main Oct 12, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Oct 12, 2021
@queengooborg queengooborg deleted the api/CanvasRenderingContext2D/smoothing_downscaling branch October 12, 2021 18:46
ddbeck added a commit that referenced this pull request Oct 12, 2021
* Bump version to v4.0.6

* Add release note for #12094

* Add release note for #12367

* Add release note for #12462

* Add release note for #12490

* Add release note for #12565

* Add release note for #12632

* Add release note for #12638

* Add release note for #12639

* Add release note for #12703

* Add release note for #12718

* Add release note for #12723

* Add release note for #12768

* Add release note for #12770

* Add release note for #12772

* Add release note for #12794

* Add release note for #12796

* Add release note for #12813

* Add stats and hoist known issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants