Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api.WindowEventHandlers.onbeforeunload.custom_text_support from BCD #13085

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Oct 24, 2021

This PR removes the irrelevant onbeforeunload.custom_text_support member of the WindowEventHandlers API as per the corresponding data guidelines. The lack of current support has been confirmed by the mdn-bcd-collector project (v4.0.0), even if the current BCD suggests support.

Note that this does not need a content update because the documentation does not mention custom text.

…m BCD

This PR removes the irrelevant `onbeforeunload.custom_text_support` member of the `WindowEventHandlers` API as per the corresponding [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features). The lack of current support has been confirmed by the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v4.0.0), even if the current BCD suggests support.
@queengooborg queengooborg added needs-release-note 📰 needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Oct 24, 2021
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 24, 2021
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Oct 24, 2021
@foolip foolip merged commit a449c02 into mdn:main Oct 25, 2021
@queengooborg queengooborg deleted the api/WindowEventHandlers/onbeforeunload/custom_text_support/removal branch October 26, 2021 03:18
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Oct 26, 2021
ddbeck added a commit that referenced this pull request Oct 26, 2021
* Bump version to v4.0.8

* Add release note for #12934

* Add release note for #13085

* Add release note for #12975

* Add release note for #12951

* Hoist known issue

* Add stats

* Fix diff link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants