Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRLightProbe: Use single entry for event #13374

Merged
merged 2 commits into from
Dec 5, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Nov 8, 2021

Summary

Companion PR for mdn/content#10373. See the discussion at https://github.com/mdn/content/discussions/9098

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 8, 2021
@@ -48,55 +48,6 @@
"deprecated": false
}
},
"onreflectionchange": {
"__compat": {
"spec_url": "https://immersive-web.github.io/lighting-estimation/#dom-xrlightprobe-onreflectionchange",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Elchi3 If we're going to have a single entry for both the event and its handler, should the spec here moved down to reflectionchange_event ? (i.e. it has an array of specs)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this is a great idea!

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 16, 2021

@Elchi3 OK, so this suggests something very interesting and slightly surprising to me: we will be omitting exposed interfaces that web developers can find and that tooling can inspect. Should we worry about that? Do we forbid any other things that are developer-exposed names? Are we OK with that?

I think if we're going to merge something like this, we ought to have data guideline that explains exactly which bits of IDL we're ruling out (e.g., "Don't create features for attribute EventHandler on*").

@Elchi3
Copy link
Member Author

Elchi3 commented Nov 16, 2021

Yes, I believe this is what we would like to do. @foolip what do you think about this?

See also #12510 which I believe goes in the same direction and suggests the same consequences.

@foolip
Copy link
Contributor

foolip commented Nov 17, 2021

We need a guideline for this, yes. It wouldn't be the first bit of IDL that's excluded though, there's already https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#constants

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 18, 2021

I forgot about the constants case. Yeah, I'm much more comfortable with this, given the precedent. I would like to see an accompanying guideline before any of these merge, so that I have something to point to in the release notes.

@Elchi3
Copy link
Member Author

Elchi3 commented Nov 18, 2021

Opened #13595 to discuss the data guideline change.

@Elchi3
Copy link
Member Author

Elchi3 commented Dec 2, 2021

Content updates merged and new events guideline is in place. This is ready.

@queengooborg queengooborg merged commit fb1eaeb into mdn:main Dec 5, 2021
@Elchi3 Elchi3 deleted the xrlightprobe-event branch December 6, 2021 10:28
@foolip
Copy link
Contributor

foolip commented Jan 5, 2022

Post-merge review in light of #13924 (comment).

Here the versions of the on* properties matched the version of the interface, so there's nothing to research. (It is possible that the event wasn't actually fired, but that's a less common situation than missing on* properties.)

jpmedley pushed a commit that referenced this pull request Jan 10, 2022
* XRLightProbe: Use single entry for event

* Add spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants