-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XRLightProbe: Use single entry for event #13374
Conversation
@@ -48,55 +48,6 @@ | |||
"deprecated": false | |||
} | |||
}, | |||
"onreflectionchange": { | |||
"__compat": { | |||
"spec_url": "https://immersive-web.github.io/lighting-estimation/#dom-xrlightprobe-onreflectionchange", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Elchi3 If we're going to have a single entry for both the event and its handler, should the spec here moved down to reflectionchange_event ? (i.e. it has an array of specs)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this is a great idea!
@Elchi3 OK, so this suggests something very interesting and slightly surprising to me: we will be omitting exposed interfaces that web developers can find and that tooling can inspect. Should we worry about that? Do we forbid any other things that are developer-exposed names? Are we OK with that? I think if we're going to merge something like this, we ought to have data guideline that explains exactly which bits of IDL we're ruling out (e.g., "Don't create features for |
We need a guideline for this, yes. It wouldn't be the first bit of IDL that's excluded though, there's already https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#constants |
I forgot about the constants case. Yeah, I'm much more comfortable with this, given the precedent. I would like to see an accompanying guideline before any of these merge, so that I have something to point to in the release notes. |
Opened #13595 to discuss the data guideline change. |
Content updates merged and new events guideline is in place. This is ready. |
Post-merge review in light of #13924 (comment). Here the versions of the on* properties matched the version of the interface, so there's nothing to research. (It is possible that the event wasn't actually fired, but that's a less common situation than missing on* properties.) |
* XRLightProbe: Use single entry for event * Add spec
Summary
Companion PR for mdn/content#10373. See the discussion at https://github.com/mdn/content/discussions/9098