Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the display_override manifest member compat data #13565

Merged
merged 6 commits into from
Dec 7, 2021

Conversation

captainbrosset
Copy link
Contributor

Summary

Over in mdn/content#10539 I'm proposing to add MDN documentation for the new Window Controls Overlay PWA feature. One part of this feature is the display_override manifest member. So in order to document it in MDN, we need its compat data here on this repo.

Test results and supporting details

The Window Controls Overlay feature is documented here: https://web.dev/window-controls-overlay/ and here https://docs.microsoft.com/en-us/microsoft-edge/progressive-web-apps-chromium/how-to/window-controls-overlay
and its current spec is on the WICG repo here: https://wicg.github.io/window-controls-overlay/#addition-of-window-controls-overlay-to-the-manifest
It was implemented in Chromium in 93 (available as origin trial then).

@github-actions github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Nov 17, 2021
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR and the background info @captainbrosset. This feature appears to be gated behind an origin trial. Since origin trials are available by time and enrollment, rather than browser version, we don't track them in BCD. Generally, we expect to cover such features only after they're generally available. With that in mind, I'm going to close this PR, but I invite you to revisit this when the feature does eventually ship. Thanks for your understanding!

The tests are failing because the spec isn't yet recognized by w3c/browser-specs. See w3c/browser-specs#416 for details.

@ddbeck ddbeck closed this Nov 30, 2021
@captainbrosset
Copy link
Contributor Author

@ddbeck the feature is planned to be generally available in chromium 98. This means it's already today available in Chrome/Edge Canary without having to turn any flags on. I just tested again today, made sure the Window Controls Overlay flag was off in edge://flags (or chrome://flags) and installed a PWA that made use of the feature. It did work correctly.

Do you want to wait until 98 becomes stable, or do we also track pre-release features in BCD (granted they're not gated behind a pref/flag and origin trial)?

@captainbrosset
Copy link
Contributor Author

captainbrosset commented Nov 30, 2021

Also, this PR is about the display_override manifest member which has been implemented in 89, and not only related to the Window Controls Overlay feature. This feature makes use of it, but the manifest member wasn't added only for this.

I should have been clearer about this in the PR description. Because I'm doing this work in the context of the WCO feature, I gave context mostly about it. But again, the display_overide field is mostly disconnected from this.

As another source of data, here is the chromestatus.com entry: https://www.chromestatus.com/feature/5728570678706176

@ddbeck ddbeck reopened this Nov 30, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 30, 2021

Ah, sorry, I've misunderstood some details. I've reopened and I'll come back to this.

@Elchi3
Copy link
Member

Elchi3 commented Dec 6, 2021

The tests are failing because the spec isn't yet recognized by w3c/browser-specs. See w3c/browser-specs#416 for details.

I've merged #13882. Please merge main into this PR and the tests should hopefully pass.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra information on this, @captainbrosset. It makes sense now and I'll go ahead and merge this. 🎉

@ddbeck ddbeck merged commit e442cf4 into mdn:main Dec 7, 2021
@captainbrosset
Copy link
Contributor Author

Awesome, thanks a lot!

@captainbrosset captainbrosset deleted the display_override branch December 7, 2021 13:32
jpmedley pushed a commit that referenced this pull request Jan 10, 2022
* Adding the display_override manifest member compat

* Changed false to null

* Corrected the spec link

* Corrected the version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants