-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the display_override manifest member compat data #13565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR and the background info @captainbrosset. This feature appears to be gated behind an origin trial. Since origin trials are available by time and enrollment, rather than browser version, we don't track them in BCD. Generally, we expect to cover such features only after they're generally available. With that in mind, I'm going to close this PR, but I invite you to revisit this when the feature does eventually ship. Thanks for your understanding!
The tests are failing because the spec isn't yet recognized by w3c/browser-specs. See w3c/browser-specs#416 for details.
@ddbeck the feature is planned to be generally available in chromium 98. This means it's already today available in Chrome/Edge Canary without having to turn any flags on. I just tested again today, made sure the Window Controls Overlay flag was off in edge://flags (or chrome://flags) and installed a PWA that made use of the feature. It did work correctly. Do you want to wait until 98 becomes stable, or do we also track pre-release features in BCD (granted they're not gated behind a pref/flag and origin trial)? |
Also, this PR is about the I should have been clearer about this in the PR description. Because I'm doing this work in the context of the WCO feature, I gave context mostly about it. But again, the As another source of data, here is the chromestatus.com entry: https://www.chromestatus.com/feature/5728570678706176 |
Ah, sorry, I've misunderstood some details. I've reopened and I'll come back to this. |
I've merged #13882. Please merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra information on this, @captainbrosset. It makes sense now and I'll go ahead and merge this. 🎉
Awesome, thanks a lot! |
* Adding the display_override manifest member compat * Changed false to null * Corrected the spec link * Corrected the version number
Summary
Over in mdn/content#10539 I'm proposing to add MDN documentation for the new Window Controls Overlay PWA feature. One part of this feature is the
display_override
manifest member. So in order to document it in MDN, we need its compat data here on this repo.Test results and supporting details
The Window Controls Overlay feature is documented here: https://web.dev/window-controls-overlay/ and here https://docs.microsoft.com/en-us/microsoft-edge/progressive-web-apps-chromium/how-to/window-controls-overlay
and its current spec is on the WICG repo here: https://wicg.github.io/window-controls-overlay/#addition-of-window-controls-overlay-to-the-manifest
It was implemented in Chromium in 93 (available as origin trial then).