Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events guideline: Single entry for event and onXXX event handler #13595

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Events guideline: Single entry for event and onXXX event handler #13595

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
670a0ad
Events guideline: Single entry for event and onXXX event handler
Elchi3 Nov 18, 2021
cceaa94
Suggest note text
Elchi3 Nov 23, 2021
8151bff
Feedback
Elchi3 Nov 29, 2021
3f7b7a9
Update docs/data-guidelines.md
Elchi3 Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/data-guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,15 @@ For example, the feature for a `focus` event targeting the `Element` interface w
}
```

This rule applies to the event features themselves, not the features for the event handlers. For example, `focus_event` and `onfocus` are two separate features.
The event handler `onfocus` is included in the `focus_event` entry. If an implementation doesn't support the event handler property, use `partial_implementation`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you suggest what the note text should be?

Can you also say what should happen if onfocus is supported but the "focus" event cannot be fired? That can mess with feature detection, but I think we should probably still just not record it in BCD.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a note text

If a specification has two sections (the event handler property and the event name), add both specification links.

This practice emerged through several discussions:

- [#935](https://github.com/mdn/browser-compat-data/issues/935#issuecomment-464691417)
- [#3420](https://github.com/mdn/browser-compat-data/pull/3420)
- [#3469](https://github.com/mdn/browser-compat-data/pull/3469)
- [mdn/content#9098](https://github.com/mdn/content/discussions/9098)

## Secure context required (`secure_context_required`)

Expand Down