Add Edge versions for api.IDBVersionChangeEvent.version #13741
Conversation
This PR adds real values for Microsoft Edge for the `version` member of the `IDBVersionChangeEvent` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v4.0.0). Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/IDBVersionChangeEvent/version _Check out the [collector's guide on how to review this PR](https://github.com/foolip/mdn-bcd-collector#reviewing-bcd-changes)._
github-actions
bot
added
the
data:api
| @@ -253,7 +253,7 @@ | |||
| "version_added": "18" | |||
| }, | |||
| "edge": { | |||
| "version_added": "≤18" | |||
| "version_added": "79" | |||
There was a problem hiding this comment.
https://staging-dot-mdn-bcd-collector.appspot.com/tests/api/IDBVersionChangeEvent/version returns false on Edge 96. Has it been removed again?
There was a problem hiding this comment.
Looks like it's false for Chrome as well, hmm...
There was a problem hiding this comment.
Looks like it's not in Chromium or Gecko source:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/indexeddb/idb_version_change_event.idl
https://github.com/mozilla/gecko-dev/blob/master/dom/webidl/IDBVersionChangeEvent.webidl
Can you check if it was ever there? If it was removed long enough ago, we can just remove this entry.
There was a problem hiding this comment.
The test is returning false all the way back in Chrome 37, and even in Firefox 40. That's enough evidence that this feature can be considered irrelevant and can be removed. I'll open a PR to do so!
This PR removes the irrelevant `version` member of the `IDBVersionChangeEvent` API as per the corresponding [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features). The lack of current support has been confirmed by the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v4.0.0), even if the current BCD suggests support. (Verification performed in mdn#13741.)
This PR removes the irrelevant `version` member of the `IDBVersionChangeEvent` API as per the corresponding [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features). The lack of current support has been confirmed by the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v4.0.0), even if the current BCD suggests support. (Verification performed in #13741.)
This PR adds real values for Microsoft Edge for the
versionmember of theIDBVersionChangeEventAPI, based upon results from the mdn-bcd-collector project (v4.0.0).Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/IDBVersionChangeEvent/version (will be added in collector v4.1)
Check out the collector's guide on how to review this PR.