Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket: Single event entries #13802

Merged
merged 2 commits into from
Dec 16, 2021
Merged

WebSocket: Single event entries #13802

merged 2 commits into from
Dec 16, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Nov 29, 2021

See #13595 for the proposed guideline.

@Elchi3 Elchi3 added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Nov 29, 2021
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 29, 2021
ddbeck
ddbeck approved these changes Dec 14, 2021
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending content changes.

@Elchi3 Elchi3 mentioned this pull request Dec 15, 2021
Merged
@Elchi3 Elchi3 removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Dec 16, 2021
@Elchi3 Elchi3 merged commit 2134aa3 into mdn:main Dec 16, 2021
@Elchi3 Elchi3 deleted the websocket-events branch December 16, 2021 15:19
@foolip
Copy link
Contributor

foolip commented Jan 5, 2022

Post-merge review in light of #13924 (comment).

The only version discrepancy here is that the error event is marked supported from Chrome 5 instead of 4 like the parent interface and the other events. However, this checks out, it was added after the rest of the events:
https://trac.webkit.org/changeset/55573/webkit
https://trac.webkit.org/browser/webkit/trunk/WebCore/Configurations/Version.xcconfig?rev=55573

jpmedley pushed a commit that referenced this pull request Jan 10, 2022
@Elchi3 @jpmedley
WebSocket: Single event entries (#13802)
ecda715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elchi3 @foolip @ddbeck