Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WakeLockSentinel: onrelease -> release_event #13816

Merged
merged 2 commits into from
Dec 5, 2021
Merged

WakeLockSentinel: onrelease -> release_event #13816

merged 2 commits into from
Dec 5, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Nov 30, 2021

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 30, 2021
@Elchi3 Elchi3 added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Nov 30, 2021
@Elchi3 Elchi3 mentioned this pull request Dec 2, 2021
Merged
@Elchi3
Copy link
Member Author

Elchi3 commented Dec 2, 2021

Content work: mdn/content#10925

@Elchi3 Elchi3 removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Dec 2, 2021
queengooborg
queengooborg approved these changes Dec 5, 2021
View reviewed changes
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks a little odd but the changes look good! 👍

@queengooborg queengooborg merged commit fdf8143 into mdn:main Dec 5, 2021
@Elchi3 Elchi3 deleted the wakelocksentinel-event branch December 5, 2021 15:15
@foolip
Copy link
Contributor

foolip commented Jan 5, 2022

Post-merge review in light of #13924 (comment).

Here the versions of the on* properties matched the version of the interface, so there's nothing to research. (It is possible that the event wasn't actually fired, but that's a less common situation than missing on* properties.)

jpmedley pushed a commit that referenced this pull request Jan 10, 2022
@Elchi3 @jpmedley
WakeLockSentinel: onrelease -> release_event (#13816)
5855edf 
* WakeLockSentinel: onrelease -> release_event

* sort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elchi3 @foolip @queengooborg