Add new manifest members. #13899
Merged
Add new manifest members. #13899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:html
|
@tomayac Please look this over. |
tomayac
reviewed
Dec 7, 2021
| "version_added": false | ||
| }, | ||
| "samsunginternet_android": { | ||
| "version_added": false |
There was a problem hiding this comment.
The latest Chromium engine the release notes mention is still Chromium 87.4280, so false might actually be correct. @torgo to verify.
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
It looks like they're ignoring all the nesting. I don't think we can deal with the issue in this PR. @Elchi3 What was the thinking behind this? |
|
Brain not working. I would just make one the child of the other in the same file (just like all the other BCD.) |
|
Now it's nested. |
Elchi3
reviewed
Dec 8, 2021
Co-authored-by: Florian Scholz <[email protected]>
Elchi3
approved these changes
Dec 8, 2021
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jpmedley
added a commit
that referenced
this pull request
Jan 10, 2022
* Add new manifest members. * Update html/manifest/display_override.json Co-authored-by: Thomas Steiner <[email protected]> * Update html/manifest/display_override.json Co-authored-by: Thomas Steiner <[email protected]> * Update html/manifest/display_override.json Co-authored-by: Thomas Steiner <[email protected]> * Properly nest manifest elements. * Fix value for Android Opera. * Update html/manifest/note_taking.json Co-authored-by: Florian Scholz <[email protected]> Co-authored-by: Thomas Steiner <[email protected]> Co-authored-by: Florian Scholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display_override
note_taking and new_note_url