Fix PositionOptions secure context information
#2447
Conversation
ExE-Boss
force-pushed
the
api/parser-options
branch
from
2041a86 to
bc18361
Compare
ddbeck
added
the
data:api
| "version_added": null | ||
| }, | ||
| "webview_android": { | ||
| "version_added": false |
There was a problem hiding this comment.
Seems like more than just a rearranging of the data happened here. Is there more to the story behind version "47" going away for WebView?
There was a problem hiding this comment.
I used the information from the Legacy compatibility table and cross-referenced this with the information in Geolocation.
| "version_added": "47" | ||
| }, | ||
| "edge": { | ||
| "version_added": null |
There was a problem hiding this comment.
The original note says secure context was not required, yet this isn't false. Is there more to the story here?
| "version_added": null | ||
| }, | ||
| "edge_mobile": { | ||
| "version_added": null |
There was a problem hiding this comment.
Same as Edge desktop before it. This seems contrary to the prior data
api/PositionOptions.json
Outdated
| "version_removed": "55", | ||
| "notes": "Secure context not required" | ||
| } | ||
| ], | ||
| "ie": { | ||
| "version_added": "9", | ||
| "notes": "Secure context not required" |
There was a problem hiding this comment.
I think this note can be removed
| "enableHighAccuracy": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/PositionOptions/enableHighAccuracy", | ||
| "support": { | ||
| "webview_android": { |
There was a problem hiding this comment.
This change (sorting the browsers?) seems to be unrelated to the topic of the PR. I don't mind incidental clean ups in the course of another change, but for future reference, it's easier to understand and review when those changes happen in their own commits
api/PositionOptions.json
Outdated
| @@ -159,14 +154,20 @@ | |||
| }, | |||
| { | |||
| "version_added": "10", | |||
| "version_removed": "15" | |||
There was a problem hiding this comment.
This is a substantive change that seems out of scope with the topic of the PR. Can you submit this change separately with the story behind it?
There was a problem hiding this comment.
Opera for Android began using Blink in version 14 (see also #1712).
There was a problem hiding this comment.
I’ve now moved this to #2468.
api/PositionOptions.json
Outdated
| @@ -219,14 +217,20 @@ | |||
| }, | |||
| { | |||
| "version_added": "10", | |||
| "version_removed": "15" | |||
There was a problem hiding this comment.
As before, this is seems out of scope
api/PositionOptions.json
Outdated
| @@ -279,14 +280,20 @@ | |||
| }, | |||
| { | |||
| "version_added": "10", | |||
| "version_removed": "15" | |||
There was a problem hiding this comment.
As before, this seems out of scope
ExE-Boss
changed the title
ParserOptions secure context informationPositionOptions secure context information
ExE-Boss
force-pushed
the
api/parser-options
branch
from
b649dcd to
508301f
Compare
|
Thanks for the clarifications, @ExE-Boss! 🎉 |
This fixes @gsouquet’s #2283.
review?(@Elchi3)