fix(css): fix edge_mobile support table for gap, row-gap and column-gap #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
added
the
data:css
|
review?(@erikadoyle, @libbymc) |
|
Thanks @kumarharsh! Pulling the Edge mobile values sounds good, but could we retain Edge 16 for desktop? We shipped updated grid in EdgeHTML 16, and I just confirmed your codepen works on that build. (Edge 16 introduced non-prefixed properties alongside the previous grid-* aliases). |
|
Ok. I actually verified it on Edge 17 - had no idea it was included since Edge 16. Nice! I'll update the PR. |
|
@kumarharsh Do you still plan to update this PR? It also needs a rebase now. |
|
Sorry, it kinda slipped below my radar. I'll update it today :) |
- edge version 16 supports unprefixed gap* properties see codepen.io/anon/pen/zLKbvJ - there *was* no edge mobile v16 so I've removed all mention of v16 for edge mobile
Elchi3
approved these changes
Aug 21, 2018
Elchi3
changed the title
This was referenced Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://codepen.io/anon/pen/zLKbvJ