-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes the lint output less verbose #2528
Conversation
This is neat looking, @caugner! That said, it seems to break the behavior of the Finally, I feel kinda unequipped to review adding a dependency, so this may need to wait for Florian's return. |
* Uses ora to display a spinner with succeed/fail feedback. * Removes `console.log` calls for succeeding checks.
Note that I have meanwhile fixed the problem (which existed before and you can see in the last screenshot I posted) that |
@Elchi3 Is there anything I can do to push this towards the release train? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this took so long to get to, @caugner! I've tested this locally with a few different error cases and I think it improves the log very well and is much more concise.
An enhancement might be to trim this even further and show the check mark only alongside directories that are all good and not list all files in that case. I'll defer that to a new issue or PR, though.
console.log
calls for succeeding checks.