Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat data for CSS [repeating-]radial-gradient #2876

Merged
merged 13 commits into from
Oct 11, 2018

Conversation

queengooborg
Copy link
Contributor

This is to check off yet another listing on #2684. All of the data is based off of the existing compatibility table, as well as a little backup from the data on https://caniuse.com.

@ExE-Boss
Copy link
Contributor

Last I checked, gradients were being handled by @teoli2003 (#2792 and #2846)

@queengooborg
Copy link
Contributor Author

I assumed that they were taking care of just the linear-gradient and repeating-linear-gradient, and didn't see anything regarding radial-gradient or repeating-radial-gradient. So, since it was something on the checklist of things that needed to be converted, I decided to try and tackle it, haha. 😛

@queengooborg queengooborg changed the title Add compat data for CSS radial-gradient Add compat data for CSS [repeating-]radial-gradient Sep 27, 2018
@teoli2003 teoli2003 self-assigned this Sep 27, 2018
@teoli2003
Copy link
Contributor

I'll happily review this once PR #2846 is merged 👍

@queengooborg
Copy link
Contributor Author

Thanks, @teoli2003!

@Elchi3 Elchi3 added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Sep 27, 2018
@teoli2003
Copy link
Contributor

Now that PR #2846 is merged, I will schedule some time next week to review this.

@Elchi3 Elchi3 requested a review from teoli2003 October 2, 2018 12:40
@Elchi3
Copy link
Member

Elchi3 commented Oct 5, 2018

Needs a rebase now, sorry :)

@queengooborg
Copy link
Contributor Author

Not a problem! The merge conflict was 100% my own fault, haha -- I sorted browsers for css/* and then sorted them again for the file this PR affects. XD Merge conflicts eliminated now!

@Elchi3 Elchi3 removed the request for review from teoli2003 October 11, 2018 13:38
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for your work! 👍

@Elchi3 Elchi3 merged commit 9479fe2 into mdn:master Oct 11, 2018
@queengooborg queengooborg deleted the css-compat-data-3 branch October 14, 2018 08:06
rachelandrew pushed a commit to rachelandrew/browser-compat-data that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants