Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up descriptions in compat-data.schema.json #3100

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

a2sheppy
Copy link
Contributor

Fixed a number of grammar errors and minor mistakes
in the descriptions of the fields in the schema. The
biggest fix is that the explanation of the
partial_implementation flag could have been interpreted
backward.

Fixed a number of grammar errors and minor mistakes
in the descriptions of the fields in the schema. The
biggest fix is that the explanation of the
`partial_implementation` flag could have been interpreted
backward.
@Elchi3 Elchi3 added the schema Isses or pull requests regarding the JSON schema files used in this project. label Nov 21, 2018
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this! 👍 The descriptions are from our schema readme file. I'd like to keep them in sync, so if you update the descriptions here, please also do so in the readme.

See, e.g. https://github.com/mdn/browser-compat-data/blob/master/schemas/compat-data-schema.md#flags or https://github.com/mdn/browser-compat-data/blob/master/schemas/compat-data-schema.md#partial_implementation

@a2sheppy
Copy link
Contributor Author

@Elchi3 - Please have a look at the revised PR and approve if you're happy with my changes. Thank you!

@a2sheppy
Copy link
Contributor Author

a2sheppy commented Jan 4, 2019

Awaiting re-review from @Elchi3 when he's back from break.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thank you! 👍

@Elchi3 Elchi3 merged commit 97b72ea into mdn:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema Isses or pull requests regarding the JSON schema files used in this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants