Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Edge Mobile 16/17/18 #3117

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Remove Edge Mobile 16/17/18 #3117

merged 2 commits into from
Jan 8, 2019

Conversation

saschanaz
Copy link
Contributor

Fixes #3116

@Elchi3 Elchi3 added the not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Nov 26, 2018
@kumarharsh
Copy link
Contributor

@Elchi3 why is this marked as not ready?

@saschanaz
Copy link
Contributor Author

@kumarharsh I think it's because the Edge team didn't respond yet: #3116 (comment)

@kumarharsh
Copy link
Contributor

kumarharsh commented Dec 27, 2018 •
edited
Loading

Per this comment from the Edge team, we can remove versions of Edge mobile after v15, as that was the last one which came. All features which landed after v15 in desktop never landed in mobile.

@ddbeck ddbeck requested a review from Elchi3 January 7, 2019 12:04
@saschanaz saschanaz mentioned this pull request Jan 8, 2019
Merged
@Elchi3
Copy link
Member

Elchi3 commented Jan 8, 2019

Per this comment from the Edge team, we can remove versions of Edge mobile after v15, as that was the last one which came. All features which landed after v15 in desktop never landed in mobile.

Nice finding! In this case, we can probably remove them.
Both, Edge and Edge mobile versions will need some work this year as they switch engines, but I think for now we can remove Edge Mobile 16-18.

This PR needs to update https://github.com/mdn/browser-compat-data/blob/master/browsers/edge_mobile.json accordingly and rebase against latest master.

@Elchi3 Elchi3 added rebase-needed 🚧 and removed not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. labels Jan 8, 2019
Elchi3
Elchi3 requested changes Jan 8, 2019
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update https://github.com/mdn/browser-compat-data/blob/master/browsers/edge_mobile.json accordingly and rebase against latest master.

@saschanaz
Copy link
Contributor Author

Done 👍

Elchi3
Elchi3 approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. In the future, we need to further clarify the Edge (Mobile) situation, but for now this seems fine. I hope to talk to MS representatives fairly soon.

@Elchi3 Elchi3 added data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. and removed rebase-needed 🚧 labels Jan 8, 2019
@Elchi3 Elchi3 merged commit 32060d8 into mdn:master Jan 8, 2019
@saschanaz saschanaz deleted the no-edge-mobile branch January 8, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:browsers Data about browsers (versions, release dates, etc). This data is used for validation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschanaz @kumarharsh @Elchi3