[All] Improvements to RTCPeerConnection.json #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
added
the
data:api
ddbeck
approved these changes
Jan 14, 2019
|
Looks good, thank you @jpmedley! 🎉 |
foolip
pushed a commit
that referenced
this pull request
Sep 23, 2021
This PR corrects the data throughout the RTCPeerConnection API, which was a **big** mess, mostly due to copy-paste error. The fixes include the following: - Converts the "Promise-based version" notes into subfeatures. It is more standard to use a subfeature rather than the notes. Additionally, they were copied and pasted all across the Opera data, so it caused some major data discrepancies. (Particularly, claiming support for features in Opera that weren't supported, wrong version numbers...) Fixes #11158. - Corrects the data regarding promise-based versions for Chrome. After further digging in, it turns out that most of these features had the wrong version number. New data comes from the commit history ([1](https://source.chromium.org/chromium/chromium/src/+/e16c96f5a5b517a64fdbc5be75f05e359e04b461), [2](https://source.chromium.org/chromium/chromium/src/+/70302a3d99ed149d59acf592edf9d32d4fd0dbda), [3](https://source.chromium.org/chromium/chromium/src/+/68f8e256dc7c7369127bd345100bcf776fa8acc0)). - Corrects the Samsung Internet and Opera/Opera Android data. In the case of Samsung Internet, it appears to have been set to 6.0 most everywhere after a mirroring from the old, incorrect wiki data (#1606), and Opera's data initially came from the wiki tables (#1070). When the Chrome data was corrected, however (see #3287), only the Chrome, Chrome Android, and WebView data was adjusted, leaving these other browsers untouched. - Corrects the version number for `createDataChannel` based upon results from the mdn-bcd-collector project (v3.3.0). - Finally, mirrors the Chrome data to both Chrome Android and WebView. Both had been left as `true` for many of the features, however since we have ranged values, we're able to replace the `true` with `≤37` for WebView, and mirror Chrome straight to Chrome Android since we know Chrome Android has supported this API back then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-Chrome changes came from Confluence. The Confluence data on this interface turned out to be really bad. You will wonder if some of these changes are correct. Here's the proof.
The webkit prefix was removed in Chrome 56. It appears that the prefix was only ever on the interface and not it’s individual members. I might have found this odd, but I’ve seen it before.
constructor
Missing from IDL, not supported: defaultIceServers, peerIdentity, sctp,onidentityresult, onidpassertionerror, onidpvalidationerror, onpeeridentity, getIdentityAssertion, setIdentityProvider, onicecandidateerror, getDefaultIceServers
Promise-based createAnswer, createOffer and createAnswer added, createOffer added
Promise-based addIceCandidate, setLocalDescription, setRemoteDescription
addTrack(), getSenders(), onTrack, removeTrack()
iceConnectionState, signalingState
iceGatheringState
localDescription, remoteDescription, setLocalDescription(), setRemoteDescription()
localStreams, remoteStreams, addStream(), removeStream(), onaddstream, onremovestream
createDataChannel, ondatachannel
updateIce(), addIceCandidate(), iceState, onicecandidate
oniceconnectionstatechange, onsignalingstatechange
onnegotationneeded
connectionstate, onconnectionstatechagne
currentLocalDescription, pendingLocalDescription, currentRemoteDescription, pendingRemoteDescription
connectionState, onconnectionstatechange
onicegatheringstatechange
onnegotiationneeded
addTransceiver
generateCertificate
getConfiguration
getLocalStreams, getRemoteStreams
getReceivers
getStats, Promise-based, resolves to RTCStatsReport, MediaStreamTrack parameter
Remove getStreamById
setConfiguration
createDTMFSender
close