Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Edge Mobile (from browsers, schema, etc.) #4280

Merged
merged 3 commits into from
Jul 4, 2019
Merged

Remove Edge Mobile (from browsers, schema, etc.) #4280

merged 3 commits into from
Jul 4, 2019

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Jun 8, 2019 •
edited
Loading

This is a PR based off of #3888. Since the Windows Phone OS is deprecated platform, Edge Mobile is as well. It was mentioned that Microsoft suggested we drop Edge Mobile.

@queengooborg queengooborg requested a review from Elchi3 as a code owner June 8, 2019 21:52
This was referenced Jun 8, 2019
Merged
Merged
@queengooborg queengooborg added the data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. label Jun 8, 2019
@queengooborg queengooborg mentioned this pull request Jun 25, 2019
Merged
@bershanskiy bershanskiy mentioned this pull request Jul 2, 2019
Merged
5 tasks
@queengooborg queengooborg changed the title Remove Edge Mobile Remove Edge Mobile (from browsers, schema, etc.) Jul 2, 2019
@queengooborg queengooborg mentioned this pull request Jul 4, 2019
Closed
@ddbeck ddbeck added infra Infrastructure issues (npm, GitHub Actions, releases) of this project docs Issues or pull requests regarding the documentation of this project. schema Isses or pull requests regarding the JSON schema files used in this project. labels Jul 4, 2019
ddbeck
ddbeck approved these changes Jul 4, 2019
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! 🎉

@ddbeck ddbeck merged commit 115d07f into mdn:master Jul 4, 2019
@queengooborg queengooborg deleted the edge-mobile/main branch July 4, 2019 11:36
@queengooborg
Copy link
Contributor Author

Woohoo! 🎉🎊

@ddbeck ddbeck mentioned this pull request Jul 4, 2019
Closed
@Elchi3 Elchi3 removed their request for review July 8, 2019 10:30
@Elchi3
Copy link
Member

Elchi3 commented Jul 8, 2019

Great work, everyone! ❤️

@queengooborg queengooborg added the scripts Issues or pull requests regarding the scripts in scripts/. label Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. docs Issues or pull requests regarding the documentation of this project. infra Infrastructure issues (npm, GitHub Actions, releases) of this project schema Isses or pull requests regarding the JSON schema files used in this project. scripts Issues or pull requests regarding the scripts in scripts/.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@queengooborg @Elchi3 @ddbeck