Remove Edge Mobile in css/* #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queengooborg
added
the
data:css
ddbeck
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
This looks fine to me. Thank you, @vinyldarkscratch. 🎉
For the record, this was my approach to reviewing this:
- Scrolled through the full diff quickly ✅
- Made sure there are no unexpected files in the list ✅
- Closely reviewed the diff for the top three files by number of changes (
git diff --stat master...) ✅ - Closely reviewed the diff for thirty files (about 5%) selected at random ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR based off of #3888. Since the Windows Phone OS is deprecated platform, Edge Mobile is as well. It was mentioned that Microsoft suggested we drop Edge Mobile.