Remove Edge Mobile (remaining data) #4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching the remaining Edge Mobile instances! To keep this PR small and within a mergeable scope (at least by yours truly), would you be willing to undo all the changes that #4280 does? That way, we can get this merged right away! (Mostly asking because my access role prevents me from merging pull requests that modify the schema, browsers, or linter. :P) |
Remove data not removed by earlier commits: - api/HTMLTrackElement.json - css/properties/background-clip.json - css/properties/clip-path.json - css/properties/list-style-type.json - css/properties/text-align.json - css/properties/user-select.json - css/properties/width.json - html/elements/track.json
|
@vinyldarkscratch Does this look better? |
queengooborg
added
data:api
queengooborg
approved these changes
Jul 3, 2019
bershanskiy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some Edge Mobile data remaining in the repository.
Summary
This removes remaining
edge_mobileinformation.Data
This removes data seen if you run
grep -r "edge_mobile" ./.This happens to be a super set of #4280.
Details
Remove all remaining edge_mobile data and references to edge_mobile:
types.d.ts, and .vscode/snippets.code-snippets
Related issues
#3888 and all issues and commits mentioned there.
Tests
Linter tests pass normally.
A checklist to help your pull request get merged faster: