Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSSTransition API data #6372

Merged
merged 8 commits into from
Aug 3, 2020
Merged

Conversation

queengooborg
Copy link
Contributor

This PR adds data for the CSSTransition API based upon manual testing. This API is a part of a W3C draft.

@ghost ghost added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 3, 2020
@Elchi3
Copy link
Member

Elchi3 commented Jul 3, 2020

/cc our Web Animation API expert @lpd-au :)

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this class has no constructor

@queengooborg
Copy link
Contributor Author

queengooborg commented Jul 23, 2020

Strangely enough, it seems Firefox and Safari both have a constructor implemented, even though that's not defined by the spec (and also why I thought Chrome had no support). I removed the constructor data from the file, but considering this, would it be better to re-add it and mark it as non-standard, @Elchi3?

@ddbeck
Copy link
Collaborator

ddbeck commented Jul 27, 2020

The spec says CSSTransition inherits from Animation which does have a constructor. If the browsers are implementing it, we ought to have data for it and I think it's standards track.

This reverts commit a6aa3c1.
@jpmedley
Copy link
Contributor

jpmedley commented Jul 29, 2020

@vinyldarkscratch You should ping the spec authors to be sure. It's possible the spec is out of date with some standards resolution. It doesn't happen often, but it does happen.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit 6686fc2 into mdn:master Aug 3, 2020
@queengooborg queengooborg deleted the api/CSSTransition branch September 16, 2020 17:11
queengooborg added a commit to queengooborg/browser-compat-data that referenced this pull request Jan 8, 2023
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `CSSTransition` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v7.1.3).

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/CSSTransition

_Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._

---

This data was originally set to "78" in mdn#6372.  This data had come from reading through the IDL and using commit history to determine when the feature was implemented (see mdn#6372 (comment)).  Since Edge was set to "84" in mdn#9190, it makes less sense to keep Chrome at "78".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants