-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSSTransition API data #6372
Conversation
/cc our Web Animation API expert @lpd-au :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this class has no constructor
Strangely enough, it seems Firefox and Safari both have a constructor implemented, even though that's not defined by the spec (and also why I thought Chrome had no support). I removed the constructor data from the file, but considering this, would it be better to re-add it and mark it as non-standard, @Elchi3? |
Co-authored-by: Joe Medley <[email protected]>
The spec says |
This reverts commit a6aa3c1.
@vinyldarkscratch You should ping the spec authors to be sure. It's possible the spec is out of date with some standards resolution. It doesn't happen often, but it does happen. |
Co-authored-by: Joe Medley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `CSSTransition` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v7.1.3). Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/CSSTransition _Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._ --- This data was originally set to "78" in mdn#6372. This data had come from reading through the IDL and using commit history to determine when the feature was implemented (see mdn#6372 (comment)). Since Edge was set to "84" in mdn#9190, it makes less sense to keep Chrome at "78".
This PR adds data for the CSSTransition API based upon manual testing. This API is a part of a W3C draft.