Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in CSS.vmin #6507

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Fix a typo in CSS.vmin #6507

merged 2 commits into from
Aug 10, 2020

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Aug 10, 2020 •
edited
Loading

The vmin method of the CSS API was accidentally typed as wmin instead. This PR corrects that.

Screen Shot 2020-08-09 at 18 35 01

(Diff view is a bit off 'cause of sorting as well.)

@ghost ghost added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 10, 2020
Elchi3
Elchi3 approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding! 👍

@Elchi3 Elchi3 merged commit 7cfec2b into master Aug 10, 2020
@Elchi3 Elchi3 deleted the api/css-vmin branch August 10, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@queengooborg @Elchi3 @ddbeck