Remove the Gamepad() constructor subfeature #6664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in mdn#1760. However, there's no constructor in https://w3c.github.io/gamepad/#gamepad-interface and it appears there never was from the spec repo's history. One gets Gamepad objects from `navigator.getGamepads()` and can't create them. That browsers also don't support the constructor was verified by their absense in source code: - Chromium: https://chromium.googlesource.com/chromium/src/+/9b50996d6e44f8b5140c33758be20d5a687a8eae/third_party/blink/renderer/modules/gamepad/gamepad.idl - Gecko: https://hg.mozilla.org/mozilla-central/file/f22c20641704d783097b1b128d826c8460de7354/dom/webidl/Gamepad.webidl - WebKit: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Modules/gamepad/Gamepad.idl?rev=266799 Additionally, `new Gamepad()` was tested in Chrome 85, Edge 18, Firefox 80 and Safari 13.1, and found to throw the same error as for another non-constructor, `new MediaError()`: https://software.hixie.ch/utilities/js/live-dom-viewer/saved/8445
github-actions
bot
added
the
data:api
|
@foolip the needs-release-note label is enough. Thank you! |
jpmedley
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in #1760.
However, there's no constructor in https://w3c.github.io/gamepad/#gamepad-interface
and it appears there never was from the spec repo's history. One gets
Gamepad objects from
navigator.getGamepads()and can't create them.That browsers also don't support the constructor was verified by their
absense in source code:
Additionally,
new Gamepad()was tested in Chrome 85, Edge 18, Firefox80 and Safari 13.1, and found to throw the same error as for another
non-constructor,
new MediaError():https://software.hixie.ch/utilities/js/live-dom-viewer/saved/8445